Use project path instead of working directory to resolve launchSettings.json#23184
Merged
Use project path instead of working directory to resolve launchSettings.json#23184
Conversation
921ae7e to
c0d099b
Compare
TanayParikh
approved these changes
Dec 30, 2021
Contributor
|
Looks like the CI isn't happy yet though 👀 |
pranavkm
added a commit
that referenced
this pull request
Jan 3, 2022
…gs.json (#23184) * Use project path instead of working directory to resolve launchSettings.json Fixes dotnet/aspnetcore#35393 * Update DotNetWatcherTests.cs
pranavkm
added a commit
that referenced
this pull request
Jan 3, 2022
* Assume basline capabilities (#23185) In a Blazor app, the apply-update capabilities are available after the app is up and running in the browser. Occasionally it takes long for the app to start up and our baseline task times out. Currently we return an empty list of capabilities which causes the compiler to produce no deltas. This PR bumps up the timeout ever so slightly and returns baseline capabilities instead. Fixes dotnet/aspnetcore#36723 * Use project path instead of working directory to resolve launchSettings.json (#23184) * Use project path instead of working directory to resolve launchSettings.json Fixes dotnet/aspnetcore#35393 * Update DotNetWatcherTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/aspnetcore#35393
dotnet-watch attempts to read the app's launchSettings.json to read things like the launch URL. Currently the URL is read relative to the working directory (it looks for
$WorkDir/Properties/launchSettings.json). However, this is incorrect if the--projectoption is used to specify a project path / directory. This change updates the code to use the project directory and adds a couple of tests.