Skip to content

[master] Update dependencies from dotnet/aspnetcore#14338

Merged
dotnet-maestro[bot] merged 60 commits intomasterfrom
darc-master-352f2605-4b05-443e-a84d-85bf9b5cfc1b
Nov 12, 2020
Merged

[master] Update dependencies from dotnet/aspnetcore#14338
dotnet-maestro[bot] merged 60 commits intomasterfrom
darc-master-352f2605-4b05-443e-a84d-85bf9b5cfc1b

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Oct 27, 2020

This pull request updates the following dependencies

From https://github.com/dotnet/aspnetcore

  • Subscription: c0c2be01-34a3-46d9-31fe-08d7a4f3bc87
  • Build: 20201111.2
  • Date Produced: 11/11/2020 5:08 PM
  • Commit: 9f72904328357d3747cd605b6e44b9d82065b9bb
  • Branch: refs/heads/master

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.NET.ILLink.Tasks: from 6.0.0-alpha.1.20527.2 to 6.0.0-alpha.1.20516.1 (parent: Microsoft.NETCore.App.Internal)

dotnet-maestro bot and others added 19 commits October 27, 2020 09:08
…0201027.1

dotnet-dev-certs , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.Analyzers , dotnet-watch , dotnet-user-secrets , Microsoft.AspNetCore.App.Ref , Microsoft.NET.Sdk.Razor , Microsoft.NET.Sdk.BlazorWebAssembly , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.DeveloperCertificates.XPlat , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers
 From Version 6.0.0-alpha.1.20526.6 -> To Version 6.0.0-alpha.1.20527.1
…0201027.2

dotnet-dev-certs , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.Analyzers , dotnet-watch , dotnet-user-secrets , Microsoft.AspNetCore.App.Ref , Microsoft.NET.Sdk.Razor , Microsoft.NET.Sdk.BlazorWebAssembly , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.DeveloperCertificates.XPlat , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers
 From Version 6.0.0-alpha.1.20526.6 -> To Version 6.0.0-alpha.1.20527.2
…0201027.4

dotnet-dev-certs , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.Analyzers , dotnet-watch , dotnet-user-secrets , Microsoft.AspNetCore.App.Ref , Microsoft.NET.Sdk.Razor , Microsoft.NET.Sdk.BlazorWebAssembly , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.DeveloperCertificates.XPlat , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers
 From Version 6.0.0-alpha.1.20526.6 -> To Version 6.0.0-alpha.1.20527.4
…0201027.7

dotnet-dev-certs , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.Analyzers , dotnet-watch , dotnet-user-secrets , Microsoft.AspNetCore.App.Ref , Microsoft.NET.Sdk.Razor , Microsoft.NET.Sdk.BlazorWebAssembly , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.DeveloperCertificates.XPlat , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers
 From Version 6.0.0-alpha.1.20526.6 -> To Version 6.0.0-alpha.1.20527.7
…0201027.10

dotnet-dev-certs , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.Analyzers , dotnet-watch , dotnet-user-secrets , Microsoft.AspNetCore.App.Ref , Microsoft.NET.Sdk.Razor , Microsoft.NET.Sdk.BlazorWebAssembly , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.DeveloperCertificates.XPlat , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers
 From Version 6.0.0-alpha.1.20526.6 -> To Version 6.0.0-alpha.1.20527.10
…0201027.11

Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Ref , dotnet-watch , dotnet-user-secrets , dotnet-dev-certs , Microsoft.AspNetCore.Analyzers , Microsoft.NET.Sdk.Razor , Microsoft.NET.Sdk.BlazorWebAssembly , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.DeveloperCertificates.XPlat
 From Version 6.0.0-alpha.1.20526.6 -> To Version 6.0.0-alpha.1.20527.11
…0201027.12

Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Ref , dotnet-watch , dotnet-user-secrets , dotnet-dev-certs , Microsoft.AspNetCore.Analyzers , Microsoft.NET.Sdk.Razor , Microsoft.NET.Sdk.BlazorWebAssembly , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.DeveloperCertificates.XPlat
 From Version 6.0.0-alpha.1.20526.6 -> To Version 6.0.0-alpha.1.20527.12
…0201028.3

Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Ref , dotnet-watch , dotnet-user-secrets , dotnet-dev-certs , Microsoft.AspNetCore.Analyzers , Microsoft.NET.Sdk.Razor , Microsoft.NET.Sdk.BlazorWebAssembly , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.DeveloperCertificates.XPlat
 From Version 6.0.0-alpha.1.20526.6 -> To Version 6.0.0-alpha.1.20528.3

Dependency coherency updates

Microsoft.NET.ILLink.Tasks
 From Version 6.0.0-alpha.1.20527.2 -> To Version 6.0.0-alpha.1.20516.1 (parent: Microsoft.NETCore.App.Internal
…er-352f2605-4b05-443e-a84d-85bf9b5cfc1b
…0201028.6

Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Ref , dotnet-watch , dotnet-user-secrets , dotnet-dev-certs , Microsoft.AspNetCore.Analyzers , Microsoft.NET.Sdk.Razor , Microsoft.NET.Sdk.BlazorWebAssembly , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.DeveloperCertificates.XPlat
 From Version 6.0.0-alpha.1.20526.6 -> To Version 6.0.0-alpha.1.20528.6

Dependency coherency updates

Microsoft.NET.ILLink.Tasks
 From Version 6.0.0-alpha.1.20527.2 -> To Version 6.0.0-alpha.1.20516.1 (parent: Microsoft.NETCore.App.Internal
…0201029.2

Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Ref , dotnet-watch , dotnet-user-secrets , dotnet-dev-certs , Microsoft.AspNetCore.Analyzers , Microsoft.NET.Sdk.Razor , Microsoft.NET.Sdk.BlazorWebAssembly , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.DeveloperCertificates.XPlat
 From Version 6.0.0-alpha.1.20526.6 -> To Version 6.0.0-alpha.1.20529.2
…0201029.8

Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Ref , dotnet-watch , dotnet-user-secrets , dotnet-dev-certs , Microsoft.AspNetCore.Analyzers , Microsoft.NET.Sdk.Razor , Microsoft.NET.Sdk.BlazorWebAssembly , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.DeveloperCertificates.XPlat
 From Version 6.0.0-alpha.1.20526.6 -> To Version 6.0.0-alpha.1.20529.8
…0201030.2

Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Ref , dotnet-watch , dotnet-user-secrets , dotnet-dev-certs , Microsoft.AspNetCore.Analyzers , Microsoft.NET.Sdk.Razor , Microsoft.NET.Sdk.BlazorWebAssembly , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.DeveloperCertificates.XPlat
 From Version 6.0.0-alpha.1.20526.6 -> To Version 6.0.0-alpha.1.20530.2
…0201031.2

Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Ref , dotnet-watch , dotnet-user-secrets , dotnet-dev-certs , Microsoft.AspNetCore.Analyzers , Microsoft.NET.Sdk.Razor , Microsoft.NET.Sdk.BlazorWebAssembly , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.DeveloperCertificates.XPlat
 From Version 6.0.0-alpha.1.20526.6 -> To Version 6.0.0-alpha.1.20531.2
…0201102.2

Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Ref , dotnet-watch , dotnet-user-secrets , dotnet-dev-certs , Microsoft.AspNetCore.Analyzers , Microsoft.NET.Sdk.Razor , Microsoft.NET.Sdk.BlazorWebAssembly , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.DeveloperCertificates.XPlat
 From Version 6.0.0-alpha.1.20526.6 -> To Version 6.0.0-alpha.1.20552.2
…0201102.3

Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Ref , dotnet-watch , dotnet-user-secrets , dotnet-dev-certs , Microsoft.AspNetCore.Analyzers , Microsoft.NET.Sdk.Razor , Microsoft.NET.Sdk.BlazorWebAssembly , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.DeveloperCertificates.XPlat
 From Version 6.0.0-alpha.1.20526.6 -> To Version 6.0.0-alpha.1.20552.3
…0201102.4

Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Ref , dotnet-watch , dotnet-user-secrets , dotnet-dev-certs , Microsoft.AspNetCore.Analyzers , Microsoft.NET.Sdk.Razor , Microsoft.NET.Sdk.BlazorWebAssembly , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.DeveloperCertificates.XPlat
 From Version 6.0.0-alpha.1.20526.6 -> To Version 6.0.0-alpha.1.20552.4
…0201102.7

Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Ref , dotnet-watch , dotnet-user-secrets , dotnet-dev-certs , Microsoft.AspNetCore.Analyzers , Microsoft.NET.Sdk.Razor , Microsoft.NET.Sdk.BlazorWebAssembly , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.DeveloperCertificates.XPlat
 From Version 6.0.0-alpha.1.20526.6 -> To Version 6.0.0-alpha.1.20552.7
@wli3
Copy link

wli3 commented Nov 3, 2020

Depend on this to be done and update stage 0 dotnet/installer#8966

dotnet-maestro bot and others added 3 commits November 3, 2020 22:18
…0201103.3

Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Ref , dotnet-watch , dotnet-user-secrets , dotnet-dev-certs , Microsoft.AspNetCore.Analyzers , Microsoft.NET.Sdk.Razor , Microsoft.NET.Sdk.BlazorWebAssembly , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.DeveloperCertificates.XPlat
 From Version 6.0.0-alpha.1.20526.6 -> To Version 6.0.0-alpha.1.20553.3
…0201104.2

Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Ref , dotnet-watch , dotnet-user-secrets , dotnet-dev-certs , Microsoft.AspNetCore.Analyzers , Microsoft.NET.Sdk.Razor , Microsoft.NET.Sdk.BlazorWebAssembly , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.DeveloperCertificates.XPlat
 From Version 6.0.0-alpha.1.20526.6 -> To Version 6.0.0-alpha.1.20554.2
@mmitche
Copy link
Member

mmitche commented Nov 4, 2020

@wli3 Any idea why the stage0 update didn't work here?

@ViktorHofer
Copy link
Member

cc @wtgodbe @dougbu

@mmitche
Copy link
Member

mmitche commented Nov 4, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sbomer
Copy link
Member

sbomer commented Nov 10, 2020

That would be good for this test. I'm still generally concerned that tests which explicitly target net5.0 might not be running against the right bits.

@vitek-karas
Copy link
Member

It should be possible to build net5.0 projects with 6.0 SDK. Better question is how do they run, since by default roll forward over major is not enabled.

…0201110.5

Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Ref , dotnet-watch , dotnet-user-secrets , dotnet-dev-certs , Microsoft.AspNetCore.Analyzers , VS.Redist.Common.AspNetCore.SharedFramework.x64.6.0 , Microsoft.NET.Sdk.Razor , Microsoft.NET.Sdk.BlazorWebAssembly , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.DeveloperCertificates.XPlat
 From Version 6.0.0-alpha.1.20526.6 -> To Version 6.0.0-alpha.1.20560.5
@dsplaisted
Copy link
Member

It should be possible to build net5.0 projects with 6.0 SDK. Better question is how do they run, since by default roll forward over major is not enabled.

We install the previous runtimes in order to enable this.

The 5.0 runtime was added in this commit: f263313

However, it may need to be updated to the GA version now.

@agocke
Copy link
Member

agocke commented Nov 11, 2020

Sorry, digging through a pile of email from last week, just saw this. Looking as well.

@sbomer
Copy link
Member

sbomer commented Nov 11, 2020

FWIW, I haven't been able to repro locally (on ubuntu) the behavior where a test requests 5.0 but gets 6.0 - I suspect it only shows up in CI.

…0201110.11

Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.Analyzers , dotnet-watch , dotnet-user-secrets , dotnet-dev-certs , VS.Redist.Common.AspNetCore.SharedFramework.x64.6.0 , Microsoft.NET.Sdk.Razor , Microsoft.NET.Sdk.BlazorWebAssembly , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.DeveloperCertificates.XPlat
 From Version 6.0.0-alpha.1.20526.6 -> To Version 6.0.0-alpha.1.20560.11
…0201110.17

Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.Analyzers , dotnet-watch , dotnet-user-secrets , dotnet-dev-certs , VS.Redist.Common.AspNetCore.SharedFramework.x64.6.0 , Microsoft.NET.Sdk.Razor , Microsoft.NET.Sdk.BlazorWebAssembly , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.DeveloperCertificates.XPlat
 From Version 6.0.0-alpha.1.20526.6 -> To Version 6.0.0-alpha.1.20560.17
@ViktorHofer
Copy link
Member

The crossgen2 and r2r tests are still failing. Who is currently investigating? Asking as Matt and I would want to get post-build signing unblocked which depends on this.

@mangod9
Copy link
Member

mangod9 commented Nov 11, 2020

@AntonLapounov for Crossgen2. Appears to be using an RC1 version of crossgen2 which had this issue. It was fixed in rtm builds:

error :   An assembly specified in the application dependencies manifest (crossgen2.deps.json) was not found: [F:\workspace\_work\1\s\artifacts\tmp\Debug\TestProjectPu---56D735CE\Crossgen2TestApp\Crossgen2TestApp.csproj]\r\nF:\workspace\_work\1\s\artifacts\bin\redist\Debug\dotnet\sdk\6.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Publish.targets(398,5): error :     package: 'runtimepack.Microsoft.NETCore.App.Runtime.win-x64', version: '5.0.0-rc.1.20451.14' 
[F:\workspace\_work\1\s\artifacts\tmp\Debug\TestProjectPu---56D735CE\Crossgen2TestApp\Crossgen2TestApp.csproj]\r\nF:\workspace\_work\1\s\artifacts\bin\redist\Debug\dotnet\sdk\6.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Publish.targets(398,5): 
error :     path: 'System.IO.Pipelines.dll'

…0201111.2

Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.Analyzers , dotnet-watch , dotnet-user-secrets , dotnet-dev-certs , VS.Redist.Common.AspNetCore.SharedFramework.x64.6.0 , Microsoft.NET.Sdk.Razor , Microsoft.NET.Sdk.BlazorWebAssembly , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.DeveloperCertificates.XPlat
 From Version 6.0.0-alpha.1.20526.6 -> To Version 6.0.0-alpha.1.20561.2
@mmitche
Copy link
Member

mmitche commented Nov 11, 2020

@AntonLapounov for Crossgen2. Appears to be using an RC1 version of crossgen2 which had this issue. It was fixed in rtm builds:

error :   An assembly specified in the application dependencies manifest (crossgen2.deps.json) was not found: [F:\workspace\_work\1\s\artifacts\tmp\Debug\TestProjectPu---56D735CE\Crossgen2TestApp\Crossgen2TestApp.csproj]\r\nF:\workspace\_work\1\s\artifacts\bin\redist\Debug\dotnet\sdk\6.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Publish.targets(398,5): error :     package: 'runtimepack.Microsoft.NETCore.App.Runtime.win-x64', version: '5.0.0-rc.1.20451.14' 
[F:\workspace\_work\1\s\artifacts\tmp\Debug\TestProjectPu---56D735CE\Crossgen2TestApp\Crossgen2TestApp.csproj]\r\nF:\workspace\_work\1\s\artifacts\bin\redist\Debug\dotnet\sdk\6.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Publish.targets(398,5): 
error :     path: 'System.IO.Pipelines.dll'

I think this is coming through the SDK that is being used in here. Did this get fixed in the 6.0 SDK?

@mangod9
Copy link
Member

mangod9 commented Nov 11, 2020

Appears to be fixed in the runtime repo as of dotnet/runtime@df87d73#diff-8df3cd354bc584349d04ad5675b33c042d8b99b741b8b95af394c55e0f5001bf.

Wonder if the tests need an update to use the correct cg2 version?

@dsplaisted
Copy link
Member

Appears to be fixed in the runtime repo as of dotnet/runtime@df87d73#diff-8df3cd354bc584349d04ad5675b33c042d8b99b741b8b95af394c55e0f5001bf.

Wonder if the tests need an update to use the correct cg2 version?

The way to do this would be to update the stage 0 SDK to one that includes that runtime change.

@mmitche
Copy link
Member

mmitche commented Nov 11, 2020

Appears to be fixed in the runtime repo as of dotnet/runtime@df87d73#diff-8df3cd354bc584349d04ad5675b33c042d8b99b741b8b95af394c55e0f5001bf.
Wonder if the tests need an update to use the correct cg2 version?

The way to do this would be to update the stage 0 SDK to one that includes that runtime change.

It does have that commit in the stage0. The stage0 has https://github.com/dotnet/runtime/commits/598426c8ccf2d1d41038d711f2187899d50ff367 right now, which is a runtime from Nov 2.

@AntonLapounov
Copy link
Member

We are no longer using stage 0 SDK for crossgen2/r2r tests. Log files tell me the tests end up using Crossgen2PackVersion="5.0.0-rc.2.20475.5" in this PR.

@mmitche
Copy link
Member

mmitche commented Nov 11, 2020

We are no longer using stage 0 SDK for crossgen2/r2r tests. Log files tell me the tests end up using Crossgen2PackVersion="5.0.0-rc.2.20475.5" in this PR.

That's somewhat surprising after updating to the 5.0.0 runtime in 3220f7b. Are you looking at the latest results?

@AntonLapounov
Copy link
Member

@mmitche Yes, I am looking at the latest results and I see two Crossgen2 packs in build logs, version 6.0.0-alpha.1.20552.4 and 5.0.0-rc.2.20475.5. There is no 5.0.0 version.

@AntonLapounov
Copy link
Member

@mmitche The installer repo still uses 5.0.0-rc.2.20475.5 for .NET 5.0: dotnet/installer#8974.

@AntonLapounov
Copy link
Member

I think if we replace net5.0 with net6.0 for these three Crossgen2 tests: https://github.com/dotnet/sdk/pull/14183/files, they should pick up the 6.0 version of the Crossgen2 pack and should pass.

@mmitche
Copy link
Member

mmitche commented Nov 11, 2020

@mmitche The installer repo still uses 5.0.0-rc.2.20475.5 for .NET 5.0: dotnet/installer#8974.

Oh oh nice. let me fix that.

@dotnet-maestro dotnet-maestro bot merged commit 1523882 into master Nov 12, 2020
@dotnet-maestro dotnet-maestro bot deleted the darc-master-352f2605-4b05-443e-a84d-85bf9b5cfc1b branch November 12, 2020 02:32
@sdmaclea
Copy link
Contributor

Woo Hoo

@mangod9
Copy link
Member

mangod9 commented Nov 12, 2020

Very nice. Assume this now unblocks osx-arm64 installer builds?. Is there anything else blocking that?

@sdmaclea
Copy link
Contributor

sdmaclea commented Nov 12, 2020

@mangod9 It has to propagate to installer. It will probably end up merging with dotnet/installer#9058 once the merge conflicts in that PR are resolved.

@mmitche
Copy link
Member

mmitche commented Nov 12, 2020

YES!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.