Skip to content

[master] Update dependencies from dotnet/sdk#8966

Merged
dotnet-maestro[bot] merged 36 commits intomasterfrom
darc-master-e43dc338-58af-4dcb-8f48-e598405b6d80
Nov 3, 2020
Merged

[master] Update dependencies from dotnet/sdk#8966
dotnet-maestro[bot] merged 36 commits intomasterfrom
darc-master-e43dc338-58af-4dcb-8f48-e598405b6d80

Conversation

@dotnet-maestro
Copy link

@dotnet-maestro dotnet-maestro bot commented Oct 22, 2020

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.WindowsDesktop.App.Ref: from 5.0.0-rc.1.20417.4 to 6.0.0-alpha.1.20531.1 (parent: Microsoft.NET.Sdk)
    • Microsoft.WindowsDesktop.App: from 5.0.0-rc.1.20417.4 to 6.0.0-alpha.1.20531.1 (parent: Microsoft.NET.Sdk)
    • Microsoft.NETCore.App.Ref: from 6.0.0-alpha.1.20513.9 to 6.0.0-alpha.1.20551.7 (parent: Microsoft.NET.Sdk)
    • Microsoft.NETCore.App.Internal: from 6.0.0-alpha.1.20513.9 to 6.0.0-alpha.1.20551.7 (parent: Microsoft.NET.Sdk)
    • Microsoft.NETCore.App.Runtime.win-x64: from 6.0.0-alpha.1.20513.9 to 6.0.0-alpha.1.20551.7 (parent: Microsoft.NET.Sdk)
    • Microsoft.NETCore.App.Host.win-x64: from 6.0.0-alpha.1.20513.9 to 6.0.0-alpha.1.20551.7 (parent: Microsoft.NET.Sdk)
    • Microsoft.NETCore.DotNetHostResolver: from 6.0.0-alpha.1.20513.9 to 6.0.0-alpha.1.20551.7 (parent: Microsoft.NET.Sdk)
    • Microsoft.NETCore.Platforms: from 6.0.0-alpha.1.20513.9 to 6.0.0-alpha.1.20551.7 (parent: Microsoft.NET.Sdk)
    • Microsoft.AspNetCore.App.Ref: from 6.0.0-alpha.1.20513.8 to 6.0.0-alpha.1.20526.6 (parent: Microsoft.NET.Sdk)
    • Microsoft.AspNetCore.App.Ref.Internal: from 6.0.0-alpha.1.20513.8 to 6.0.0-alpha.1.20526.6 (parent: Microsoft.NET.Sdk)
    • Microsoft.AspNetCore.App.Runtime.win-x64: from 6.0.0-alpha.1.20513.8 to 6.0.0-alpha.1.20526.6 (parent: Microsoft.NET.Sdk)
    • dotnet-dev-certs: from 6.0.0-alpha.1.20513.8 to 6.0.0-alpha.1.20526.6 (parent: Microsoft.NET.Sdk)
    • dotnet-user-secrets: from 6.0.0-alpha.1.20513.8 to 6.0.0-alpha.1.20526.6 (parent: Microsoft.NET.Sdk)
    • dotnet-watch: from 6.0.0-alpha.1.20513.8 to 6.0.0-alpha.1.20526.6 (parent: Microsoft.NET.Sdk)
    • Microsoft.DotNet.Common.ItemTemplates: from 6.0.0-alpha.1.20514.1 to 6.0.0-alpha.1.20552.1 (parent: Microsoft.NET.Sdk)
    • Microsoft.Dotnet.WinForms.ProjectTemplates: from 5.0.0-rc.1.20417.1 to 6.0.0-alpha.1.20528.3 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64)
    • Microsoft.WindowsDesktop.App.Runtime.win-x64: from 5.0.0-rc.1.20417.4 to 6.0.0-alpha.1.20531.1 (parent: Microsoft.NET.Sdk)
    • Microsoft.DotNet.Wpf.ProjectTemplates: from 5.0.0-rc.1.20417.3 to 6.0.0-alpha.1.20529.2 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64)
    • Microsoft.NET.Test.Sdk: from 16.9.0-preview-20201013-01 to 16.8.0-release-20201022-02 (parent: Microsoft.NET.Sdk)
    • Microsoft.NET.ILLink.Tasks: from 6.0.0-alpha.1.20514.1 to 6.0.0-alpha.1.20527.2 (parent: Microsoft.NET.Sdk)
    • Microsoft.Net.Compilers.Toolset: from 3.9.0-1.20513.7 to 3.9.0-2.20552.4 (parent: Microsoft.NET.Sdk)
    • Microsoft.Build: from 16.9.0-preview-20513-07 to 16.9.0-preview-20530-04 (parent: Microsoft.NET.Sdk)
    • NuGet.Build.Tasks: from 5.8.0-rc.6860 to 5.8.0-rc.6930 (parent: Microsoft.NET.Sdk)

From https://github.com/dotnet/sdk

  • Subscription: 6f9c7b2d-c29c-4b2f-fcec-08d7d0f045ee
  • Build: 20201103.1
  • Date Produced: 11/3/2020 10:32 AM
  • Commit: 637aaef
  • Branch: refs/heads/master

Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-alpha.1.20514.6 -> To Version 6.0.100-alpha.1.20522.3

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,Microsoft.WindowsDesktop.App,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Internal,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,dotnet-dev-certs,dotnet-user-secrets,dotnet-watch,Microsoft.DotNet.Common.ItemTemplates,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset
 From Version 5.0.0-rc.1.20417.4 -> To Version 6.0.0-alpha.1.20516.1 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-alpha.1.20514.6 -> To Version 6.0.100-alpha.1.20522.4

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,Microsoft.WindowsDesktop.App,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Internal,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,dotnet-dev-certs,dotnet-user-secrets,dotnet-watch,Microsoft.DotNet.Common.ItemTemplates,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build
 From Version 5.0.0-rc.1.20417.4 -> To Version 6.0.0-alpha.1.20516.1 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-alpha.1.20514.6 -> To Version 6.0.100-alpha.1.20523.1

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,Microsoft.WindowsDesktop.App,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Internal,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,dotnet-dev-certs,dotnet-user-secrets,dotnet-watch,Microsoft.DotNet.Common.ItemTemplates,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks
 From Version 5.0.0-rc.1.20417.4 -> To Version 6.0.0-alpha.1.20516.1 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-alpha.1.20514.6 -> To Version 6.0.100-alpha.1.20523.2

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,Microsoft.WindowsDesktop.App,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Internal,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,dotnet-dev-certs,dotnet-user-secrets,dotnet-watch,Microsoft.DotNet.Common.ItemTemplates,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks
 From Version 5.0.0-rc.1.20417.4 -> To Version 6.0.0-alpha.1.20516.1 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-alpha.1.20514.6 -> To Version 6.0.100-alpha.1.20523.3

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,Microsoft.WindowsDesktop.App,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Internal,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,dotnet-dev-certs,dotnet-user-secrets,dotnet-watch,Microsoft.DotNet.Common.ItemTemplates,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks
 From Version 5.0.0-rc.1.20417.4 -> To Version 6.0.0-alpha.1.20516.1 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-alpha.1.20514.6 -> To Version 6.0.100-alpha.1.20523.4

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,Microsoft.WindowsDesktop.App,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Internal,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,dotnet-dev-certs,dotnet-user-secrets,dotnet-watch,Microsoft.DotNet.Common.ItemTemplates,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks
 From Version 5.0.0-rc.1.20417.4 -> To Version 6.0.0-alpha.1.20516.1 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-alpha.1.20514.6 -> To Version 6.0.100-alpha.1.20523.5

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,Microsoft.WindowsDesktop.App,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Internal,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,dotnet-dev-certs,dotnet-user-secrets,dotnet-watch,Microsoft.DotNet.Common.ItemTemplates,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks
 From Version 5.0.0-rc.1.20417.4 -> To Version 6.0.0-alpha.1.20516.1 (parent: Microsoft.NET.Sdk
@ViktorHofer
Copy link
Member

@dougbu @wtgodbe any idea what why this is failing in the PR?

src/redist/targets/GenerateLayout.targets(331,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Problems downloading file from 'https://dotnetcli.blob.core.windows.net/dotnet/aspnetcore/Runtime/6.0.0-alpha.1.20513.8/aspnetcore-runtime-internal-6.0.0-alpha.1.20520.5-osx-x64.tar.gz'. Does the resource exist on the storage? NotFound : The specified blob does not exist.

Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-alpha.1.20514.6 -> To Version 6.0.100-alpha.1.20523.6

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,Microsoft.WindowsDesktop.App,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Internal,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,dotnet-dev-certs,dotnet-user-secrets,dotnet-watch,Microsoft.DotNet.Common.ItemTemplates,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks
 From Version 5.0.0-rc.1.20417.4 -> To Version 6.0.0-alpha.1.20516.1 (parent: Microsoft.NET.Sdk
@wtgodbe
Copy link
Member

wtgodbe commented Oct 23, 2020

Looking

@wtgodbe
Copy link
Member

wtgodbe commented Oct 23, 2020

https://dotnetcli.blob.core.windows.net/dotnet/aspnetcore/Runtime/6.0.0-alpha.1.20513.8/aspnetcore-runtime-internal-6.0.0-alpha.1.20520.5-osx-x64.tar.gz

That version is wrong - the archive in that folder is versioned 20513.8, not 20520.5. Checking where that version came from

@wtgodbe
Copy link
Member

wtgodbe commented Oct 23, 2020

It's because VSRedistCommonAspNetCoreSharedFrameworkx6460PackageVersion isn't getting updated, and that's what we use to calculate the folder to look in. The reason is that version.details.xml still references the package named VS.Redist.Common.AspNetCore.SharedFramework.x64.5.0, when it should be VS.Redist.Common.AspNetCore.SharedFramework.x64.6.0. I'll fix this PR

@ViktorHofer
Copy link
Member

Awesome, thanks a lot Will. Unrelated, but fingers crossed that you'll find the issues that are blocking the runtime ingestion in aspnetcore soon 💃.

Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-alpha.1.20514.6 -> To Version 6.0.100-alpha.1.20523.7

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,Microsoft.WindowsDesktop.App,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Internal,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,dotnet-dev-certs,dotnet-user-secrets,dotnet-watch,Microsoft.DotNet.Common.ItemTemplates,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks
 From Version 5.0.0-rc.1.20417.4 -> To Version 6.0.0-alpha.1.20522.1 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-alpha.1.20514.6 -> To Version 6.0.100-alpha.1.20523.10

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,Microsoft.WindowsDesktop.App,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Internal,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,dotnet-dev-certs,dotnet-user-secrets,dotnet-watch,Microsoft.DotNet.Common.ItemTemplates,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks
 From Version 5.0.0-rc.1.20417.4 -> To Version 6.0.0-alpha.1.20522.1 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-alpha.1.20514.6 -> To Version 6.0.100-alpha.1.20524.1

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,Microsoft.WindowsDesktop.App,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Internal,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,dotnet-dev-certs,dotnet-user-secrets,dotnet-watch,Microsoft.DotNet.Common.ItemTemplates,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks
 From Version 5.0.0-rc.1.20417.4 -> To Version 6.0.0-alpha.1.20522.1 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-alpha.1.20514.6 -> To Version 6.0.100-alpha.1.20524.2

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,Microsoft.WindowsDesktop.App,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Internal,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,dotnet-dev-certs,dotnet-user-secrets,dotnet-watch,Microsoft.DotNet.Common.ItemTemplates,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks
 From Version 5.0.0-rc.1.20417.4 -> To Version 6.0.0-alpha.1.20522.1 (parent: Microsoft.NET.Sdk
@ViktorHofer
Copy link
Member

@dsplaisted @wli3 any idea why the publish test is failing?

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes to stop auto-updating

@ViktorHofer
Copy link
Member

@wtgodbe the download issue is back. Can you please take another look? thanks

Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-alpha.1.20514.6 -> To Version 6.0.100-alpha.1.20526.1

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,Microsoft.WindowsDesktop.App,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Internal,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,dotnet-dev-certs,dotnet-user-secrets,dotnet-watch,Microsoft.DotNet.Common.ItemTemplates,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks
 From Version 5.0.0-rc.1.20417.4 -> To Version 6.0.0-alpha.1.20522.1 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-alpha.1.20514.6 -> To Version 6.0.100-alpha.1.20526.2

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,Microsoft.WindowsDesktop.App,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Internal,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,dotnet-dev-certs,dotnet-user-secrets,dotnet-watch,Microsoft.DotNet.Common.ItemTemplates,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks
 From Version 5.0.0-rc.1.20417.4 -> To Version 6.0.0-alpha.1.20522.1 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-alpha.1.20514.6 -> To Version 6.0.100-alpha.1.20526.3

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,Microsoft.WindowsDesktop.App,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Internal,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,dotnet-dev-certs,dotnet-user-secrets,dotnet-watch,Microsoft.DotNet.Common.ItemTemplates,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks
 From Version 5.0.0-rc.1.20417.4 -> To Version 6.0.0-alpha.1.20522.1 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-alpha.1.20514.6 -> To Version 6.0.100-alpha.1.20526.4

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,Microsoft.WindowsDesktop.App,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Internal,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,dotnet-dev-certs,dotnet-user-secrets,dotnet-watch,Microsoft.DotNet.Common.ItemTemplates,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks
 From Version 5.0.0-rc.1.20417.4 -> To Version 6.0.0-alpha.1.20522.1 (parent: Microsoft.NET.Sdk
@wtgodbe
Copy link
Member

wtgodbe commented Oct 26, 2020

VS.Redist.Common.AspNetCore.SharedFramework.x64.6.0 is still not getting auto-updated - @mmitche we updated the name of that dependency in this PR to match what's coming from Aspnetcore, but maestro still isn't auto-updating it, any idea why?

@mmitche
Copy link
Member

mmitche commented Oct 26, 2020

Maestro reads the base branch to determine dependencies to update, not this branch, so it's not going to update that until it gets checked in.

@wtgodbe
Copy link
Member

wtgodbe commented Oct 26, 2020

So we'll have to update this PR manually until it goes in. Will do that now

wtgodbe and others added 2 commits October 26, 2020 09:29
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-alpha.1.20514.6 -> To Version 6.0.100-alpha.1.20526.5

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,Microsoft.WindowsDesktop.App,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Internal,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,dotnet-dev-certs,dotnet-user-secrets,dotnet-watch,Microsoft.DotNet.Common.ItemTemplates,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks
 From Version 5.0.0-rc.1.20417.4 -> To Version 6.0.0-alpha.1.20526.2 (parent: Microsoft.NET.Sdk
@mmitche
Copy link
Member

mmitche commented Oct 27, 2020

@mmitche I thought that requesting changes in the PR should stop maestro from auto-updating the PR. Isn't that true anymore?

Only stops auto-merge.

dotnet-maestro bot and others added 3 commits October 27, 2020 21:36
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-alpha.1.20514.6 -> To Version 6.0.100-alpha.1.20527.6

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,Microsoft.WindowsDesktop.App,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Internal,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,dotnet-dev-certs,dotnet-user-secrets,dotnet-watch,Microsoft.DotNet.Common.ItemTemplates,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks
 From Version 5.0.0-rc.1.20417.4 -> To Version 6.0.0-alpha.1.20526.2 (parent: Microsoft.NET.Sdk
@ViktorHofer
Copy link
Member

OK I disabled the subscription and update the versions once more manually.

@dsplaisted @wli3 can you please take a look at the failing test? Thanks

@pr0vieh
Copy link

pr0vieh commented Oct 31, 2020

hmm any news on this ?

@wli3
Copy link

wli3 commented Nov 2, 2020

@sfoslund could you look into ItCanPublishArm64Winforms test failure?

@sfoslund
Copy link
Member

sfoslund commented Nov 2, 2020

@hoyosjs, you added this test back in when you added support, right? Do you recognize this failure?

@hoyosjs
Copy link
Member

hoyosjs commented Nov 3, 2020

I have no idea about the Linking warnings. For the winforms part, this:

F:\workspace\_work\1\s\artifacts\bin\redist\Debug\dotnet\sdk\6.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(324,5): error NETSDK1073: The FrameworkReference 'Microsoft.NETCore.App' was not recognized [F:\workspace\_work\1\s\artifacts\bin\EndToEnd.Tests\Debug\netcoreapp5.0\Tests\EndToEnd.Tests\ItCanPublishArm64Winforms\ItCanPublishArm64Winforms.csproj]
F:\workspace\_work\1\s\artifacts\bin\redist\Debug\dotnet\sdk\6.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(324,5): error NETSDK1073: The FrameworkReference 'Microsoft.WindowsDesktop.App.WindowsForms' was not recognized [F:\workspace\_work\1\s\artifacts\bin\EndToEnd.Tests\Debug\netcoreapp5.0\Tests\EndToEnd.Tests\ItCanPublishArm64Winforms\ItCanPublishArm64Winforms.csproj]

looks like a KnownFramework... reference missing for the 6.0 MNA. Testing locally to check it this is the case.

Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-alpha.1.20514.6 -> To Version 6.0.100-alpha.1.20553.1

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,Microsoft.WindowsDesktop.App,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Internal,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,dotnet-dev-certs,dotnet-user-secrets,dotnet-watch,Microsoft.DotNet.Common.ItemTemplates,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks
 From Version 5.0.0-rc.1.20417.4 -> To Version 6.0.0-alpha.1.20531.1 (parent: Microsoft.NET.Sdk
@akoeplinger
Copy link
Member

I think the 6.0 knownframework issue was recently fixed by #8973.

Bumped the version again to get a new build.

@akoeplinger
Copy link
Member

@vitek-karas do you know why the ILLink_verify_analysis_warnings_hello_world_app test would fail here:

The execution of a hello world app generated a diff in the number of warnings the app produces

This is a list of missing linker warnings generated with your change using a console app, if you are working on make things linker friendly please also submit a PR deleting these warnings:
-  ILLink : Trim analysis warning IL2072: System.Diagnostics.Tracing.NullableTypeInfo.WriteData(PropertyValue
-  ILLink : Trim analysis warning IL2026: System.Reflection.Emit.ModuleBuilder.GetGenericMethodBaseDefinition(MethodBase
This is a list of extra linker warnings generated with your change using a console app:
+  ILLink : Trim analysis warning IL2026: System.Reflection.Associates.AssignAssociates(Int32,RuntimeType,RuntimeType
+  ILLink : Trim analysis warning IL2065: System.Reflection.CustomAttribute.AddCustomAttributes(ListBuilder1&,RuntimeModule,Int32,RuntimeType,Boolean,RuntimeType.ListBuilder<Object>
+ ILLink : Trim analysis warning IL2026: System.Reflection.CustomAttribute.FilterCustomAttributeRecord(MetadataToken,MetadataImport&,RuntimeModule,MetadataToken,RuntimeType,Boolean,ListBuilder1&,RuntimeType&,IRuntimeMethodInfo&,Boolean&
+  ILLink : Trim analysis warning IL2026: System.Reflection.CustomAttribute.GetAttributeUsage(RuntimeType
+  ILLink : Trim analysis warning IL2075: System.Reflection.CustomAttributeData.CustomAttributeData(RuntimeModule,MetadataToken,ConstArray&
+  ILLink : Trim analysis warning IL2026: System.Reflection.Emit.ModuleBuilder.GetMemberRefToken(MethodBase,IEnumerable<Type>
+  ILLink : Trim analysis warning IL2072: System.Diagnostics.Tracing.NullableTypeInfo.WriteData(TraceLoggingDataCollector,PropertyValue
+  ILLink : Trim analysis warning IL2070: System.RuntimeType.GetMethodBase(RuntimeType,RuntimeMethodHandleInternal
+  ILLink : Trim analysis warning IL2055: System.Reflection.SignatureTypeExtensions.TryMakeGenericType(Type,Type[]
+  ILLink : Trim analysis warning IL2055: System.Reflection.Emit.TypeBuilderInstantiation.Substitute(Type[]

Expected: True
Actual:   False

@vitek-karas
Copy link
Member

/cc @tlakollo

That test validates that linker reports a specific set of warnings on a simple app.
In dotnet/runtime#43594 I removed some warnings produces by CoreLib.
In a reaction to that I updated the test yesterday here: dotnet/sdk@0ae5136

It's as if this PR has the new test, but old runtime bits...

@vitek-karas
Copy link
Member

I don't know how the SDK tests are executed in the installer repo... so I don't know which version of runtime the test ran against.

@ViktorHofer
Copy link
Member

@vitek-karas I assume that it uses the repo local SDK but I'm not 100% sure myself. I assume we could temporarily disable the IL link warnings?

@vitek-karas
Copy link
Member

It's definitely not a critical test - it failing doesn't break anything in the product (yet :-)). So it's OK to disable it. That said we need to figure out how come the runtime/SDK are out of sync in this case. So I'm OK disabling the test, but creating an issue to fix this soon (we want the test in the SDK repo at least - it's a way to guard against introducing new warnings into the system).

@dsplaisted
Copy link
Member

The dotnet/sdk repo publishes packages that include the tests. Those flow into dotnet/installer at the same time as the product does, and some of them are run as tests in this repo.

The list of tests to run is in https://github.com/dotnet/installer/blob/master/test/SdkTests/TestConfig.xml. You can certainly add that test method to the list of tests to skip. Probably it would start working again once the runtime flows into dotnet/installer, so it would be nice to eventually re-enable it.

@wli3 wli3 dismissed ViktorHofer’s stale review November 3, 2020 19:21

issue resolved

@dotnet-maestro dotnet-maestro bot merged commit f17cf33 into master Nov 3, 2020
@dotnet-maestro dotnet-maestro bot deleted the darc-master-e43dc338-58af-4dcb-8f48-e598405b6d80 branch November 3, 2020 21:06
@ViktorHofer
Copy link
Member

Awesome 🎉🎉🎉

@mmitche
Copy link
Member

mmitche commented Nov 3, 2020

WOO WOO!

@ViktorHofer
Copy link
Member

I just re-enabled the subscription :)

@mmitche
Copy link
Member

mmitche commented Nov 3, 2020

great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.