Skip to content

[master] Update dependencies from dotnet/runtime#14303

Merged
dotnet-maestro[bot] merged 10 commits intomasterfrom
darc-master-ac160965-c65c-4720-91ea-31b6c47f3c32
Nov 3, 2020
Merged

[master] Update dependencies from dotnet/runtime#14303
dotnet-maestro[bot] merged 10 commits intomasterfrom
darc-master-ac160965-c65c-4720-91ea-31b6c47f3c32

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Oct 23, 2020 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: ea219f43-0754-4d2f-576e-08d76e1d56cb
  • Build: 20201101.7
  • Date Produced: 11/2/2020 6:26 AM
  • Commit: ecd979c9860caee8326f8678736ae98a77bdae5b
  • Branch: refs/heads/master

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.NET.ILLink.Tasks: from 6.0.0-alpha.1.20516.1 to 6.0.0-alpha.1.20527.2 (parent: Microsoft.NETCore.App.Internal)

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2020…
c0dbae6 
…1022.9

System.CodeDom , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Host.win-x64 , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages
 From Version 6.0.0-alpha.1.20521.2 -> To Version 6.0.0-alpha.1.20522.9
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2020…
a1e0487 
…1025.3

System.CodeDom , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Host.win-x64 , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages
 From Version 6.0.0-alpha.1.20521.2 -> To Version 6.0.0-alpha.1.20525.3
@AntonLapounov
Copy link
Member

AntonLapounov commented Oct 26, 2020

There is the following failure:

Microsoft.NET.Publish.Tests.GivenThatWeWantToRunILLink.ILLink_verify_analysis_warnings_hello_world_app(targetFramework: \"net5.0\")
The execution of a hello world app generated a diff in the number of warnings the app produces

This is a list of missing linker warnings generated with your change using a console app, if you are working on make things linker friendly please also submit a PR deleting these warnings:
-  ILLink : Trim analysis warning IL2070: System.RuntimeType.GetMethodBase(RuntimeType,RuntimeMethodHandleInternal
-  ILLink : Trim analysis warning IL2026: System.Reflection.CustomAttribute.GetAttributeUsage(RuntimeType
-  ILLink : Trim analysis warning IL2065: System.Reflection.CustomAttribute.AddCustomAttributes(ListBuilder`1&,RuntimeModule,Int32,RuntimeType,Boolean,RuntimeType.ListBuilder<Object>
-  ILLink : Trim analysis warning IL2055: System.Reflection.Emit.TypeBuilderInstantiation.Substitute(Type[]
-  ILLink : Trim analysis warning IL2026: System.Reflection.CustomAttribute.FilterCustomAttributeRecord(MetadataToken,MetadataImport&,RuntimeModule,MetadataToken,RuntimeType,Boolean,ListBuilder`1&,RuntimeType&,IRuntimeMethodInfo&,Boolean&
-  ILLink : Trim analysis warning IL2075: System.Reflection.CustomAttributeData.CustomAttributeData(RuntimeModule,MetadataToken,ConstArray&
-  ILLink : Trim analysis warning IL2055: System.Reflection.SignatureTypeExtensions.TryMakeGenericType(Type,Type[]
-  ILLink : Trim analysis warning IL2026: System.Reflection.Associates.AssignAssociates(Int32,RuntimeType,RuntimeType

Expected: True
Actual:   False
   at Microsoft.NET.Publish.Tests.GivenThatWeWantToRunILLink.ILLink_verify_analysis_warnings_hello_world_app(String targetFramework) in /_/src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToRunILLink.cs:line 384

and also Microsoft.NET.Build.Tests.GivenThatWeWantToBuildAnAppWithoutTransitiveProjectRefs.It_builds_the_project_successfully_when_RAR_finds_all_references test failed with STATUS_HEAP_CORRUPTION (-1073740940), which is probably intermittent.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2020…
1985f8d 
…1027.3

System.CodeDom , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Host.win-x64 , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages
 From Version 6.0.0-alpha.1.20521.2 -> To Version 6.0.0-alpha.1.20527.3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2020…
f446ca3 
…1027.8

System.CodeDom , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Host.win-x64 , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages
 From Version 6.0.0-alpha.1.20521.2 -> To Version 6.0.0-alpha.1.20527.8
@mangod9
Copy link
Member

mangod9 commented Oct 28, 2020

@wli3 is there an ETA for getting the latest runtime+asp.net dependencies propagated to sdk? We are looking at supported macos arm64 targets and support for that is included in the runtime. Thx!

@wli3
Copy link

wli3 commented Oct 28, 2020

@mangod9 runtime, asp.net owners their flow to SDK in the end. Although @joeloff do you have an estimation from our side?

@joeloff
Copy link
Member

joeloff commented Oct 28, 2020

Nothing yet, I need to check to see if we have a new installer build ready to insert that contains the 6.0 changes Daniel made.

@mangod9
Copy link
Member

mangod9 commented Oct 29, 2020 •
edited
Loading

runtime, asp.net owners their flow to SDK in the end

Ok, thanks. Will check who manages this for runtime. @joeloff does the sdk have a dependency on the installer? I thought it was the other way -- installer will be ready once sdk has consumed the runtime packages.

dotnet-maestro bot and others added 5 commits October 29, 2020 12:13
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2020…
0fe4e85 
…1028.10

System.CodeDom , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Host.win-x64 , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages
 From Version 6.0.0-alpha.1.20521.2 -> To Version 6.0.0-alpha.1.20528.10

Dependency coherency updates

Microsoft.NET.ILLink.Tasks
 From Version 6.0.0-alpha.1.20516.1 -> To Version 6.0.0-alpha.1.20527.2 (parent: Microsoft.NETCore.App.Internal
@akoeplinger
Merge branch 'master' into darc-master-ac160965-c65c-4720-91ea-31b6c4…
cc460ab 
…7f3c32
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2020…
1c08f53 
…1030.4

System.CodeDom , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Host.win-x64 , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages
 From Version 6.0.0-alpha.1.20528.10 -> To Version 6.0.0-alpha.1.20530.4
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2020…
a48b336 
…1101.1

System.CodeDom , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Host.win-x64 , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages
 From Version 6.0.0-alpha.1.20530.4 -> To Version 6.0.0-alpha.1.20551.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2020…
896d778 
…1101.7

System.CodeDom , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Host.win-x64 , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages
 From Version 6.0.0-alpha.1.20551.1 -> To Version 6.0.0-alpha.1.20551.7
@wli3
Copy link

wli3 commented Nov 2, 2020

@vitek-karas @tlakollo could you fix the failing test? https://dev.azure.com/dnceng/public/_build/results?buildId=873483&view=ms.vss-test-web.build-test-results-tab&runId=27947008&resultId=100113&paneView=debug

@vitek-karas
Copy link
Member

vitek-karas commented Nov 2, 2020

That is caused by my dotnet/runtime#43594 - I'll update the test.

@dotnet-maestro dotnet-maestro bot merged commit 0ae5136 into master Nov 3, 2020
@dotnet-maestro dotnet-maestro bot deleted the darc-master-ac160965-c65c-4720-91ea-31b6c47f3c32 branch November 3, 2020 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@AntonLapounov @mangod9 @wli3 @joeloff @vitek-karas @akoeplinger