Show a message when building as part of dotnet-run#12581
Merged
pranavkm merged 1 commit intorelease/5.0.1xx-preview8from Jul 23, 2020
Merged
Show a message when building as part of dotnet-run#12581pranavkm merged 1 commit intorelease/5.0.1xx-preview8from
pranavkm merged 1 commit intorelease/5.0.1xx-preview8from
Conversation
* Tweak ILaunchSettingsProvider to return a LaunchSettingsResult * Read LaunchSettingsResult during dotnet-run to show message
vijayrkn
approved these changes
Jul 23, 2020
wli3
suggested changes
Jul 23, 2020
| targetCommand.EnvironmentVariable("ASPNETCORE_URLS", launchSettings.ApplicationUrl); | ||
| } | ||
|
|
||
| foreach (var entry in launchSettings.EnvironmentVariables) |
| return 1; | ||
| if (!string.IsNullOrEmpty(launchSettings.ApplicationUrl)) | ||
| { | ||
| targetCommand.EnvironmentVariable("ASPNETCORE_URLS", launchSettings.ApplicationUrl); |
Contributor
Author
|
@wli3 I wrote a functional test for the scenarios you listed to make sure previously untested code worked after I basically moved the code around. While I understand it would be great to add unit test coverage for this type, this is not the PR to do it. I'll file an issue to add additional test coverage in this area. |
Contributor
Author
|
Filed #12609 as follow up. |
I don't like this approach. And you dismissed my block directly. Unless it is really hard. Tests should go with the PR. |
warrenbuckley
pushed a commit
to umbraco/Umbraco-CMS
that referenced
this pull request
Jun 15, 2021
bergmania
pushed a commit
to umbraco/Umbraco-CMS
that referenced
this pull request
Jun 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1154478