Skip to content

[master] Update dependencies from microsoft/msbuild#12561

Merged
sfoslund merged 2 commits intomasterfrom
darc-master-e3b904a8-05b2-4ad0-8c42-e24ca5514029
Jul 21, 2020
Merged

[master] Update dependencies from microsoft/msbuild#12561
sfoslund merged 2 commits intomasterfrom
darc-master-e3b904a8-05b2-4ad0-8c42-e24ca5514029

Conversation

@dotnet-maestro
Copy link
Copy Markdown
Contributor

@dotnet-maestro dotnet-maestro bot commented Jul 20, 2020 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/microsoft/msbuild

  • Subscription: 541ffb79-a58a-4b7b-321c-08d8080363b6
  • Build: 20200721.1
  • Date Produced: 7/21/2020 4:49 PM
  • Commit: e8338f5ad91d42c3196218648859e9e837099842
  • Branch: refs/heads/master
  • Updates:
    • Microsoft.Build.Localization: from 16.8.0-preview-20367-06 to 16.8.0-preview-20371-01
    • Microsoft.Build: from 16.8.0-preview-20367-06 to 16.8.0-preview-20371-01

@dotnet-maestro
Update dependencies from https://github.com/microsoft/msbuild build 2…
a2f9199 
…0200720.5

Microsoft.Build.Localization , Microsoft.Build
 From Version 16.8.0-preview-20367-06 -> To Version 16.8.0-preview-20370-05
@dotnet-maestro
Copy link
Copy Markdown
Contributor Author

dotnet-maestro bot commented Jul 20, 2020 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ✔️ Standard Merge Policies Succeeded - Successful checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_TestAsTools Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Release), dotnet-sdk-public-ci (Build Windows_NT Build_Debug)
  • ❌ Standard Merge Policies There are reviews that have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

sfoslund
sfoslund suggested changes Jul 20, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@sfoslund sfoslund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes to ensure this doesn't automerge. @wli3 @dsplaisted, this change is necessary due to dotnet/msbuild#5501, look okay to you?

@rainersigwald
Copy link
Copy Markdown
Member

rainersigwald commented Jul 21, 2020

Was the MSBuild-side change breaking?

@dotnet-maestro
Copy link
Copy Markdown
Contributor Author

dotnet-maestro bot commented Jul 21, 2020 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ✔️ Standard Merge Policies Succeeded - Successful checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_TestAsTools Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Release), dotnet-sdk-public-ci (Build Windows_NT Build_Debug)
  • ❌ Standard Merge Policies There are reviews that have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@sfoslund
Copy link
Copy Markdown
Member

sfoslund commented Jul 21, 2020

@rainersigwald I guess so, I just found dotnet/msbuild#5435, where Daniel made his change non-breaking so I'll adapt that for mine too.

@dotnet-maestro
Copy link
Copy Markdown
Contributor Author

dotnet-maestro bot commented Jul 21, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ✔️ Standard Merge Policies Succeeded - Successful checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_TestAsTools Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Release), dotnet-sdk-public-ci (Build Windows_NT Build_Debug)
  • ❌ Standard Merge Policies There are reviews that have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@sfoslund sfoslund force-pushed the darc-master-e3b904a8-05b2-4ad0-8c42-e24ca5514029 branch from 91aa7bc to a2f9199 Compare July 21, 2020 15:21
@mmitche mmitche mentioned this pull request Jul 21, 2020
Merged
@sfoslund
Copy link
Copy Markdown
Member

sfoslund commented Jul 21, 2020

I've made a PR in MSBuild to make this change non-breaking: dotnet/msbuild#5534

@dotnet-maestro
Copy link
Copy Markdown
Contributor Author

dotnet-maestro bot commented Jul 21, 2020 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ✔️ Standard Merge Policies Succeeded - Successful checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Windows_NT_TestAsTools Build_Debug), dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Release), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Release), dotnet-sdk-public-ci (Build Windows_NT Build_Debug)
  • ❌ Standard Merge Policies There are reviews that have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@dotnet-maestro
Update dependencies from https://github.com/microsoft/msbuild build 2…
5393962 
…0200721.1

Microsoft.Build.Localization , Microsoft.Build
 From Version 16.8.0-preview-20367-06 -> To Version 16.8.0-preview-20371-01
@sfoslund sfoslund merged commit 16d1862 into master Jul 21, 2020
@sfoslund sfoslund deleted the darc-master-e3b904a8-05b2-4ad0-8c42-e24ca5514029 branch July 21, 2020 19:31
@hoyosjs hoyosjs mentioned this pull request Jul 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sfoslund sfoslund sfoslund approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rainersigwald @sfoslund