Fix API breaking change from adding SdkResolver IndicateSuccess overload#5435
Merged
dsplaisted merged 1 commit intodotnet:masterfrom Jun 17, 2020
Merged
Conversation
Member
Author
|
@Forgind @rainersigwald Any idea why there are test failures for ItemTransformContainingSemicolon_InTaskHost in this PR? |
Contributor
|
#5423 |
Member
Author
|
@Forgind So do you typically just re-run it? |
Contributor
|
That, wait for me to figure out what's wrong, or help me figure out what's wrong. |
rainersigwald
approved these changes
Jun 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5269 introduced an API breaking change by adding an overload to the
IndicateSuccessmethod of theSdkResultFactoryabstract class.This class should only be implemented by MSBuild itself and by implementors of SDK resolvers when they want to mock this class for testing. So the impact of the break is probably low, but it still seems like a good idea to fix.