Merged
Conversation
BillWagner
approved these changes
Jun 5, 2018
Member
BillWagner
left a comment
There was a problem hiding this comment.
These are really good new samples @rpetrusha
I had a couple suggestions around the output methods (both C# and VB). You can decide which you want to take, and then 
when you are ready.
| { | ||
| int i = 0; | ||
| foreach (var item in list ) | ||
| Console.WriteLine( "\t[{0}]:\t{1}", i++, item ); |
Member
There was a problem hiding this comment.
I'd use an interpolated string. You could also use a field width specifier for formatting instead of the tabs.
| Public Shared Sub PrintIndexAndValues(list As IEnumerable) | ||
| Dim i As Integer = 0 | ||
| For Each item In list | ||
| Console.WriteLine(vbTab + "[{0}]:" + vbTab + "{1}", i, item) |
Member
There was a problem hiding this comment.
I'd use string interpolation here as well (with the field with specifier.)
karelz
pushed a commit
to karelz/samples
that referenced
this pull request
Aug 31, 2018
* Revised example * Used interpolated strings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revised example
This is a revised version of the example for the IComparer interface. It includes the following changes: