Add analyzer to flag converting from DllImport to GeneratedDllImport #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Do we want to add a code fix that does the conversion as well? |
DllImportGenerator/DllImportGenerator/Analyzers/ConvertToGeneratedDllImportAnalyzer.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
I think we want a fixer eventually. For our current target of the libraries, since they are used for many target frameworks and we only support net5.0+, we'd have to use the right target framework preprocessor defines (or add a define specifically for when the P/Invoke generator is enabled). I didn't add a fixer here, since I honestly didn't want to deal with that yet and I think just flagging them provides some value right now. |
50 tasks
AaronRobinsonMSFT
approved these changes
Nov 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a coarse check to flag
DllImportmethods where switching toGeneratedDllImportcan be useful. Flags theDllImportmethod if it has one of:SetLastError=truePreserveSig=falseDisabled by default. To enable, add to editorconfig:
dotnet_diagnostic.DLLIMPORTGENANALYZER015.severity = <severity>Was able to run against a local build of libraries (not just NetCoreApp) on Windows (using https://github.com/elinor-fung/runtime/tree/useDllImportGenerator)
-os Linux: 1460 warnings-os OSX: 1210 warningscc @AaronRobinsonMSFT @jkoritzinsky