Skip to content

Add test assets for WMF to PNG conversion test #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
safern merged 1 commit into from
May 1, 2020
Merged

Add test assets for WMF to PNG conversion test #72

safern merged 1 commit into from
May 1, 2020

Conversation

@safern
Copy link
Member

@safern safern commented May 1, 2020

These assets are needed for: dotnet/runtime#35169

@safern safern mentioned this pull request May 1, 2020
Merged
ViktorHofer
ViktorHofer approved these changes May 1, 2020
View reviewed changes
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are those assets coming from? What's their license? :)

@tannergooding
Copy link
Member

tannergooding commented May 1, 2020

Do we have a NuGet package or somewhere we can add this to instead? Generally speaking, checking binary files into git isn't "best practice"...

If we are going to check them in, do we expect they will ever need to be removed or modified and if so, how frequently?

@ViktorHofer
Copy link
Member

ViktorHofer commented May 1, 2020

This repository's purpose is to generate nuget packages which are then consumed in dotnet/runtime.

@tannergooding
Copy link
Member

tannergooding commented May 1, 2020

This repository's purpose is to generate nuget packages which are then consumed in dotnet/runtime.

I completely missed the -assets part of the name. My bad 😄

@safern
Copy link
Member Author

safern commented May 1, 2020

Where are those assets coming from? What's their license? :)

Those are just dummy images a internal costumer shared with me for the repro and said it was fine to put them in GH.

@safern safern merged commit 205a003 into dotnet:master May 1, 2020
tqiu8 pushed a commit to tqiu8/runtime-assets that referenced this pull request Dec 1, 2020
@safern @tqiu8
Add test assets for WMF to PNG conversion test (dotnet#72)
9b8d624
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@tannergooding tannergooding tannergooding approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@safern @tannergooding @ViktorHofer