[wasm] Fix "we can't find snapshot urls" #99814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoeplinger
approved these changes
Mar 16, 2024
ilonatommy
added a commit
that referenced
this pull request
Mar 19, 2024
This reverts commit 55273a1.
ilonatommy
added a commit
that referenced
this pull request
Mar 19, 2024
ilonatommy
added a commit
that referenced
this pull request
Mar 22, 2024
ilonatommy
added a commit
that referenced
this pull request
Mar 25, 2024
….6312.58 (#100084) * Automated bump of chrome version * Revert #99945, #99814 * Feedback, more logging --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ilona Tomkowicz <itomkowicz@microsoft.com> Co-authored-by: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #97364.
Without this PR:
Snapshot not found (e.g. see:
https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1250580- the current value inChromeVersions.props).With this PR:
Urls of
https://storage.googleapis.com/chromium-browser-snapshots?prefix=Linux_x64/125058format - found.