Skip to content

JIT ARM64-SVE: Implement IF_SVE_FD_3A, IF_SVE_FD_3B, IF_SVE_FD_3C #97934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
amanasifkhalid merged 2 commits into from
Feb 5, 2024
Merged

JIT ARM64-SVE: Implement IF_SVE_FD_3A, IF_SVE_FD_3B, IF_SVE_FD_3C #97934

amanasifkhalid merged 2 commits into from
Feb 5, 2024

Conversation

@amanasifkhalid
Copy link
Contributor

@amanasifkhalid amanasifkhalid commented Feb 4, 2024

Part of #94549.

cstool output:

mul   z0.h, z1.h, z1.h[1]
mul   z2.h, z3.h, z3.h[3]
mul   z4.h, z5.h, z5.h[5]
mul   z6.h, z7.h, z7.h[7]
mul   z8.s, z9.s, z1.s[0]
mul   z10.s, z11.s, z3.s[1]
mul   z12.s, z13.s, z5.s[2]
mul   z14.s, z15.s, z7.s[3]
mul   z16.d, z17.d, z0.d[0]
mul   z18.d, z19.d, z5.d[1]
mul   z20.d, z21.d, z10.d[0]
mul   z22.d, z23.d, z15.d[1]

JitDisasm output:

mul     z0.h, z1.h, z1.h[1]
mul     z2.h, z3.h, z3.h[3]
mul     z4.h, z5.h, z5.h[5]
mul     z6.h, z7.h, z7.h[7]
mul     z8.s, z9.s, z1.s[0]
mul     z10.s, z11.s, z3.s[1]
mul     z12.s, z13.s, z5.s[2]
mul     z14.s, z15.s, z7.s[3]
mul     z16.d, z17.d, z0.d[0]
mul     z18.d, z19.d, z5.d[1]
mul     z20.d, z21.d, z10.d[0]
mul     z22.d, z23.d, z15.d[1]

cc @dotnet/arm64-contrib.

@amanasifkhalid amanasifkhalid added the arm-sve Work related to arm64 SVE/SVE2 support label Feb 4, 2024
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 4, 2024
@ghost ghost assigned amanasifkhalid Feb 4, 2024
@ghost
Copy link

ghost commented Feb 4, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Part of #94549.

cstool output:

mul   z0.h, z1.h, z1.h[1]
mul   z2.h, z3.h, z3.h[3]
mul   z4.h, z5.h, z5.h[5]
mul   z6.h, z7.h, z7.h[7]
mul   z8.s, z9.s, z1.s[0]
mul   z10.s, z11.s, z3.s[1]
mul   z12.s, z13.s, z5.s[2]
mul   z14.s, z15.s, z7.s[3]
mul   z16.d, z17.d, z0.d[0]
mul   z18.d, z19.d, z5.d[1]
mul   z20.d, z21.d, z10.d[0]
mul   z22.d, z23.d, z15.d[1]

JitDisasm output:

mul     z0.h, z1.h, z1.h[1]
mul     z2.h, z3.h, z3.h[3]
mul     z4.h, z5.h, z5.h[5]
mul     z6.h, z7.h, z7.h[7]
mul     z8.s, z9.s, z1.s[0]
mul     z10.s, z11.s, z3.s[1]
mul     z12.s, z13.s, z5.s[2]
mul     z14.s, z15.s, z7.s[3]
mul     z16.d, z17.d, z0.d[0]
mul     z18.d, z19.d, z5.d[1]
mul     z20.d, z21.d, z10.d[0]
mul     z22.d, z23.d, z15.d[1]

cc @dotnet/arm64-contrib.

Author: amanasifkhalid
Assignees: amanasifkhalid
Labels:

area-CodeGen-coreclr, arch-arm64-sve
Milestone: -

@amanasifkhalid amanasifkhalid mentioned this pull request Feb 4, 2024
Closed
@ryujit-bot
Copy link

ryujit-bot commented Feb 4, 2024

Diff results for #97934

Throughput diffs

Throughput diffs for linux/arm64 ran on windows/x64

MinOpts (-0.01% to +0.00%)
Collection PDIFF
libraries.pmi.linux.arm64.checked.mch -0.01%

Details here

This was referenced Feb 4, 2024
Closed
Closed
@ryujit-bot
Copy link

ryujit-bot commented Feb 4, 2024

Diff results for #97934

Throughput diffs

Throughput diffs for linux/arm64 ran on linux/x64

Overall (-0.01% to -0.00%)
Collection PDIFF
libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch -0.01%
libraries_tests.run.linux.arm64.Release.mch -0.01%
libraries.pmi.linux.arm64.checked.mch -0.01%
benchmarks.run_tiered.linux.arm64.checked.mch -0.01%
benchmarks.run_pgo.linux.arm64.checked.mch -0.01%
benchmarks.run.linux.arm64.checked.mch -0.01%
realworld.run.linux.arm64.checked.mch -0.01%
coreclr_tests.run.linux.arm64.checked.mch -0.01%
libraries.crossgen2.linux.arm64.checked.mch -0.01%
MinOpts (-0.02% to -0.00%)
Collection PDIFF
libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch -0.01%
libraries_tests.run.linux.arm64.Release.mch -0.01%
libraries.pmi.linux.arm64.checked.mch -0.01%
benchmarks.run_tiered.linux.arm64.checked.mch -0.01%
benchmarks.run_pgo.linux.arm64.checked.mch -0.01%
benchmarks.run.linux.arm64.checked.mch -0.01%
realworld.run.linux.arm64.checked.mch -0.02%
coreclr_tests.run.linux.arm64.checked.mch -0.01%
FullOpts (-0.01% to -0.00%)
Collection PDIFF
libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch -0.01%
libraries.pmi.linux.arm64.checked.mch -0.01%
benchmarks.run_tiered.linux.arm64.checked.mch -0.01%
benchmarks.run_pgo.linux.arm64.checked.mch -0.01%
benchmarks.run.linux.arm64.checked.mch -0.01%
realworld.run.linux.arm64.checked.mch -0.01%
coreclr_tests.run.linux.arm64.checked.mch -0.01%
libraries.crossgen2.linux.arm64.checked.mch -0.01%

Details here

kunalspathak
kunalspathak approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amanasifkhalid amanasifkhalid merged commit 9d7c48e into dotnet:main Feb 5, 2024
@amanasifkhalid amanasifkhalid deleted the sve-mul branch February 5, 2024 22:11
This was referenced Feb 5, 2024
Closed
Open
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@kunalspathak kunalspathak kunalspathak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@amanasifkhalid amanasifkhalid

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amanasifkhalid @ryujit-bot @kunalspathak