Skip to content

Conversation

@MichalStrehovsky
Copy link
Member

@MichalStrehovsky MichalStrehovsky commented Dec 12, 2023

Reverts #95496

This is blocking SDK integration: dotnet/sdk#37350. I tried fixing the test failures (that are due to every single test doing t:Publish), but there are still failures and the logs are useless and offer no way to corelate failures to a single test.

We don't really need erroring out that much. Ideally SDK owners will make /t:Publish to not be weird.

@ghost ghost added linkable-framework Issues associated with delivering a linker friendly framework area-Tools-ILLink .NET linker development as well as trimming analyzers labels Dec 12, 2023
@ghost
Copy link

ghost commented Dec 12, 2023

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar
See info in area-owners.md if you want to be subscribed.

Issue Details

Reverts #95496

Author: MichalStrehovsky
Assignees: -
Labels:

linkable-framework

Milestone: -

Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good for the moment but perhaps @marcpopMSFT can help with understanding how to diagnose the tests

@marcpopMSFT
Copy link
Member

This is good for the moment but perhaps @marcpopMSFT can help with understanding how to diagnose the tests
I'm not sure why in this case the Build Analysis tab failed to provide details on the test failures. I'll file a bug in the arcade repo as there's something with how the SDK is set up maybe that's fooling it.

The link to the console log is sufficient to find the test results:
Search for "[FAIL]" and you'll see NETSDK1102.

AzDO Test tab has had a years old bug that direct links to the failing test don't actually show the error message or stack trace. We should probably get them to fix that as it's really annoying that this link doesn't show the error details.

The alternative approach is to navigate to the summary of the PR build, then click tests, then click until you find the test entry. Doing that flow will get you the individual test results on the right without having to search through the helix log.
image

@MichalStrehovsky
Copy link
Member Author

The link to the console log is sufficient to find the test results:

Thank you! I think I see all the failing tests now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Tools-ILLink .NET linker development as well as trimming analyzers linkable-framework Issues associated with delivering a linker friendly framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants