-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Revert "Error out if SelfContained is not specified for Native AOT publish" #95881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar Issue DetailsReverts #95496
|
lewing
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good for the moment but perhaps @marcpopMSFT can help with understanding how to diagnose the tests
The link to the console log is sufficient to find the test results: AzDO Test tab has had a years old bug that direct links to the failing test don't actually show the error message or stack trace. We should probably get them to fix that as it's really annoying that this link doesn't show the error details. The alternative approach is to navigate to the summary of the PR build, then click tests, then click until you find the test entry. Doing that flow will get you the individual test results on the right without having to search through the helix log. |
Thank you! I think I see all the failing tests now. |

Reverts #95496
This is blocking SDK integration: dotnet/sdk#37350. I tried fixing the test failures (that are due to every single test doing
t:Publish), but there are still failures and the logs are useless and offer no way to corelate failures to a single test.We don't really need erroring out that much. Ideally SDK owners will make
/t:Publishto not be weird.