Skip to content

Conversation

@lewing
Copy link
Member

@lewing lewing commented Nov 23, 2023

so that the msi.nupkg get published

@lewing lewing requested a review from directhex November 23, 2023 09:08
@ghost ghost added the area-Build-mono label Nov 23, 2023
@ghost ghost assigned lewing Nov 23, 2023
@lewing lewing requested a review from radical November 23, 2023 09:08
@lewing lewing requested review from radical and steveisok November 23, 2023 09:09
@lewing lewing changed the title [workloads] Add the wasi-wasm cross compilers to the worklaod targets [workloads] Add the wasi-wasm cross compilers to the worklodd targets Nov 23, 2023
@lewing lewing changed the title [workloads] Add the wasi-wasm cross compilers to the worklodd targets [workloads] Add the wasi-wasm cross compilers to the workload targets Nov 23, 2023
@silesmo
Copy link

silesmo commented Nov 23, 2023

Thanks @lewing!

@lewing lewing merged commit 8c1399d into dotnet:main Nov 23, 2023
@lewing lewing deleted the wasi-msi branch November 23, 2023 16:30
@directhex
Copy link
Contributor

directhex commented Nov 23, 2023 via email

@lewing
Copy link
Member Author

lewing commented Nov 23, 2023

Does this also need updating for the musl cross compilers? Or is it only relevant on Windows?Sent from my iPhoneOn Nov 23, 2023, at 11:29 AM, Larry Ewing @.***> wrote:

Merged #95170 into main.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: @.***>

i believe this is the stage that does the windows specific repackaging for VS and the admin installer and doesn't need the cross compiler hosts for other platforms

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants