Skip to content

Conversation

@eNeRGy164
Copy link
Contributor

Fill out details for the System.Security.Cryptography.ProtectedData NuGet package readme.

See #92228

@ghost ghost added area-System.Security community-contribution Indicates that the PR has been added by a community member labels Oct 18, 2023
@ghost
Copy link

ghost commented Oct 18, 2023

Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Fill out details for the System.Security.Cryptography.ProtectedData NuGet package readme.

See #92228

Author: eNeRGy164
Assignees: -
Labels:

area-System.Security

Milestone: -


System.Security.Cryptography.ProtectedData offers a simplified interface for utilizing Microsoft Windows DPAPI's [CryptProtectData](https://learn.microsoft.com/windows/win32/api/dpapi/nf-dpapi-cryptprotectdata) and [CryptUnprotectData](https://learn.microsoft.com/windows/win32/api/dpapi/nf-dpapi-cryptunprotectdata) functions.

This library is primarily aimed at ensuring the security of critical data, like user credentials or sensitive information, either while storing or transmitting.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd delete this paragraph entirely.

The plain truth is that it's primarily aimed at people already using it. It's reasonable for storing sensitive data locally, not generally suitable for transmission (except for a domain user sending it to themselves on another computer; or for "give this back to me"), but since it's not cross-plat it's not something that we really push... so... it's there for people who were using ProtectedData in .NET Framework.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we give explicit guidance like that? Sounds almost like "don't introduce new use, consider XYZ instead"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this statement doesn't hurt the documentation, so I'm fine with it.

There is already a note about the better cross-plat support in System.Security.Cryptography.

@ViktorHofer
Copy link
Member

@adamsitnik / @jozkee please approve the PR if ready.

Copy link
Member

@jozkee jozkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jozkee jozkee merged commit 3f41ed3 into dotnet:PackageReadmesContinued Oct 19, 2023
@eNeRGy164 eNeRGy164 deleted the system-security-cryptography-protect-data branch October 19, 2023 22:07
ViktorHofer pushed a commit that referenced this pull request Oct 20, 2023
…3660)

* Provide Cryptography.ProtectedData package readme

* Processing review comments

* Remove paragraph and improve sentence

* Improve code sample
@ghost ghost locked as resolved and limited conversation to collaborators Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Security community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants