Skip to content

Conversation

@SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented Oct 17, 2023

Continuation of #93295.

Fixes #92784.
Fixes #44087.

A few diffs are expected due to the early propagation change.

@ghost ghost added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member labels Oct 17, 2023
@ghost
Copy link

ghost commented Oct 17, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #92784.

A few diffs are expected due to the early propagation change.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@SingleAccretion SingleAccretion marked this pull request as ready for review October 18, 2023 14:32
@SingleAccretion
Copy link
Contributor Author

x86 SPMI looks to have timed out; ARM64 SPMI looks to be #93527.

Diffs, @dotnet/jit-contrib.

Copy link
Member

@jakobbotsch jakobbotsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jakobbotsch jakobbotsch merged commit e0409d4 into dotnet:main Oct 25, 2023
@SingleAccretion SingleAccretion deleted the Atomics-Are-Indirs-Part-Two branch October 27, 2023 17:50
liveans pushed a commit to liveans/dotnet-runtime that referenced this pull request Nov 9, 2023
* Consider atomics throwing

* Remove the quirk

* Add a test

* Generate non-null assertions for atomics
@ghost ghost locked as resolved and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Atomics are missing from GenTree::OperExceptions [RyuJIT] Unnecessary nullcheck in Exchange_long benchmark

2 participants