Skip to content

Conversation

@eNeRGy164
Copy link
Contributor

Fill out details for the System.IO.Hashing NuGet package readme.

See #92228

@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-System.IO labels Oct 16, 2023
@ghost
Copy link

ghost commented Oct 16, 2023

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Fill out details for the System.IO.Hashing NuGet package readme.

See #92228

Author: eNeRGy164
Assignees: -
Labels:

area-System.IO, community-contribution

Milestone: -

@ViktorHofer
Copy link
Member

@dotnet/area-system-io-hashing please review this package readme PR before EOW so that we can get the change still ported into .NET 8.

@ViktorHofer
Copy link
Member

@eNeRGy164 looks like your branch has a conflict (it adds 523 commits)

@eNeRGy164
Copy link
Contributor Author

eNeRGy164 commented Oct 17, 2023

@eNeRGy164 looks like your branch has a conflict (it adds 523 commits)

Yes, I pressed the "fork sync" button on the wrong branch 😭
Will fix this in a second


Sorry for all the reviewers that suddenly were added to this PR 👀

@ghost
Copy link

ghost commented Oct 17, 2023

Tagging subscribers to this area: @dotnet/area-system-io-hashing, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Fill out details for the System.IO.Hashing NuGet package readme.

See #92228

Author: eNeRGy164
Assignees: -
Labels:

community-contribution, area-System.IO.Hashing

Milestone: -

@bartonjs
Copy link
Member

bartonjs commented Oct 17, 2023

@eNeRGy164 By the by, it's generally frowned upon to do a squash/amend during a PR (anything requiring a force-push). It makes it harder to review what got changed as a response to the feedback. (We squash it up when merging)

Yeah, there's a github feature to look at what changed in a force push, but doesn't exist in the Files changed tab/view. But, in general, the preferred form is to leave the individual commits once a PR has started.

@eNeRGy164
Copy link
Contributor Author

@eNeRGy164 By the by, it's generally frowned upon to do a squash/amend during a PR (anything requiring a force-push). It makes it harder to review what got changed as a response to the feedback. (We squash it up when merging)

Thanks for pointing that out. I didn't notice the mention on squash commit.
I'm used to work at repos where clean git history is valued, and one should not create review commits.

@ViktorHofer ViktorHofer merged commit 2610c53 into dotnet:PackageReadmesContinued Oct 18, 2023
@eNeRGy164 eNeRGy164 deleted the system-io-hashing branch October 18, 2023 09:46
@ghost ghost locked as resolved and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.IO.Hashing community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants