Skip to content

Report Exception.FullName for http.client.request.duration/error.type #93322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
antonfirsov merged 1 commit into from
Oct 12, 2023
Merged

Report Exception.FullName for http.client.request.duration/error.type #93322

antonfirsov merged 1 commit into from
Oct 12, 2023

Conversation

@antonfirsov
Copy link
Contributor

@antonfirsov antonfirsov commented Oct 11, 2023

Address #93302 as agreed. This should be backported to 8.0.

@ghost
Copy link

ghost commented Oct 11, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Address #93302 as agreed. This should be backported to 8.0.

Author: antonfirsov
Assignees: -
Labels:

area-System.Net.Http
Milestone: -

@ghost ghost assigned antonfirsov Oct 11, 2023
@karelz karelz added this to the 9.0.0 milestone Oct 11, 2023
@antonfirsov
Copy link
Contributor Author

antonfirsov commented Oct 12, 2023

The enterprise-linux build failure is unrelated.

@antonfirsov antonfirsov merged commit 0032260 into dotnet:main Oct 12, 2023
antonfirsov added a commit to antonfirsov/runtime that referenced this pull request Oct 12, 2023
@antonfirsov
Report Exception.FullName for http.client.request.duration/error.type (…
cb36f7b 
…dotnet#93322)
@antonfirsov antonfirsov mentioned this pull request Oct 12, 2023
Merged
carlossanlop pushed a commit that referenced this pull request Oct 13, 2023
@antonfirsov
[release/8.0] Adjust System.Net metrics for OTel conformance and cons…
60b77a6 
…istency (#93414)

* Rename `server.socket.address` to `network.peer.address` (#93255)

* Report Exception.FullName for http.client.request.duration/error.type (#93322)

* Adjust the DNS lookup duration metric (#93254)
@antonfirsov antonfirsov mentioned this pull request Oct 16, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@karelz karelz karelz approved these changes

@MihaZupan MihaZupan MihaZupan approved these changes

@noahfalk noahfalk Awaiting requested review from noahfalk

Assignees

@antonfirsov antonfirsov

Labels

area-System.Net.Http

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@antonfirsov @karelz @MihaZupan