[wasi] Fixes to enable more tests#82966
Conversation
This could be changed in the future to include in the single file bundle
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsThis could be changed in the future to include in the single file bundle.
|
….ExporterTypesTests.TypesTest_Negative - Issue: dotnet#82967
…ialization.Xml.ReflectionOnly.Tests Remaining fixed by adding `/tmp`
There was a problem hiding this comment.
I would like to differentiate the WasmFilesToIncludeInFileSystem vs WasmExtraFilesToDeploy.
For browser WasmFilesToIncludeInFileSystem is to VFS and WasmExtraFilesToDeploy is to web server.
For wasi VFS doesn't exist and we don't plan it. And there is no web server.
Could we have other property which would do "copy to output" under different name in WASI ?
|
@maraf could you please chime in for the new Razor static assets ? |
|
StaticWebAssets will replace WasmExtraFilesToDeploy. In the future we may use them new trait type to also replace files for VFS. I agree to have a different property WASI "files". StaticWebAssets won't touch WASI. |
|
For wasi I don't plan to keep these two properties at all, and instead completely rely on the regular None/Content types. This will be happen once the publish related integration that I had mentioned earlier is in place. |
|
So, this is temporary to get the tests working. |
Makes sense. Could you please open issue for that and put link into the code at right places. Thanks! |
Opened #83108 . Reference at specific places in the code isn't needed. |
pavelsavara
left a comment
There was a problem hiding this comment.
good as temporary solution to unblock testing
[wasi] Copy WasmFilesToIncludeInFileSystem to the bundle too
This could be changed in the future to include in the single file bundle.
System.IO.Packaging, andSystem.Data.DataSetExtensionstests.WasiAppBuilder: Create an empty /tmp
And enable
System.Runtime.Serialization.Xml.Tests, andSystem.Runtime.Serialization.Xml.ReflectionOnly.TestsTODO: single file case