[JIT] X64 - Three instruction replacement sequence for multiply in certain cases#76981
Merged
TIHan merged 25 commits intodotnet:mainfrom Oct 20, 2022
Merged
[JIT] X64 - Three instruction replacement sequence for multiply in certain cases#76981TIHan merged 25 commits intodotnet:mainfrom
TIHan merged 25 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsExperimenting based on this issue #75119
|
… Made SuperFileCheck anchors more likely to match.
Contributor
Author
|
This is ready. @dotnet/jit-contrib - @kunalspathak PTAL |
1 task
2 tasks
Contributor
Author
|
@dotnet/jit-contrib ping again, this is ready and is passing CI, diffs There is a slight size increase, but based on the perfscore, and benchmarks mentioned in the description, execution time is faster. |
Contributor
markples
reviewed
Oct 19, 2022
…y necessary. Forgot to add an additional instruction to a disasm test.
Contributor
Author
|
CI did pass except for formatting and a timeout issue. Merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Will resolve a subset of: #75119
The changes handle integer multiplication cases when a constant is one away from being the power of 2.
Some performance results are here.
Examples:
These can technically be further optimized with
leaI believe, but I'm going to do those in a separate PR.I made very trivial updates to SuperFileCheck since I encountered a bug when writing the disasm tests for this.
Acceptance Criteria