Skip to content

Limit AnalyzerLanguage in LibraryImportGenerator to C# #69680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AaronRobinsonMSFT merged 1 commit into from
May 23, 2022
Merged

Limit AnalyzerLanguage in LibraryImportGenerator to C# #69680

AaronRobinsonMSFT merged 1 commit into from
May 23, 2022

Conversation

@AaronRobinsonMSFT
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT commented May 23, 2022

Fixes #69233

Resurrect and expand #69253

@AaronRobinsonMSFT AaronRobinsonMSFT added area-System.Runtime.InteropServices source-generator Indicates an issue with a source generator feature labels May 23, 2022
@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 7.0.0 milestone May 23, 2022
@ghost
Copy link

ghost commented May 23, 2022

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #69233

Resurrect and expand #69253

Author: AaronRobinsonMSFT
Assignees: -
Labels:

area-System.Runtime.InteropServices, source-generator
Milestone: 7.0.0

@elinor-fung
Copy link
Member

elinor-fung commented May 23, 2022

We'll also need to keep an eye out for this flowing to sdk and update the test:
https://github.com/dotnet/sdk/blob/5f64de40b65f5e1154b3309339563335d8b15d3e/src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToUseAnalyzers.cs#L73-L74

AaronRobinsonMSFT added a commit to dotnet/sdk that referenced this pull request May 23, 2022
@AaronRobinsonMSFT
Respond to dotnet/runtime#69680
621121d 
Required SDK test updates for when dotnet/runtime changes in dotnet/runtime#69680 flow to SDK.
@AaronRobinsonMSFT AaronRobinsonMSFT mentioned this pull request May 23, 2022
Closed
@AaronRobinsonMSFT
Copy link
Member Author

AaronRobinsonMSFT commented May 23, 2022

We'll also need to keep an eye out for this flowing to sdk and update the test: https://github.com/dotnet/sdk/blob/5f64de40b65f5e1154b3309339563335d8b15d3e/src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToUseAnalyzers.cs#L73-L74

Thanks. I've created a PR that can be merged in when the SDK updates.

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit dfedca1 into dotnet:main May 23, 2022
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the runtime_69233 branch May 23, 2022 20:37
AaronRobinsonMSFT added a commit to dotnet/sdk that referenced this pull request May 24, 2022
@AaronRobinsonMSFT
Respond to dotnet/runtime#69680
8fa555c 
Required SDK test updates for when dotnet/runtime changes in dotnet/runtime#69680 flow to SDK.
dotnet-maestro bot added a commit to dotnet/sdk that referenced this pull request May 24, 2022
@dotnet-maestro
[main] Update dependencies from dotnet/runtime (#25608)
306035d 
[main] Update dependencies from dotnet/runtime


 - Respond to dotnet/runtime#69680

Required SDK test updates for when dotnet/runtime changes in dotnet/runtime#69680 flow to SDK.
@ghost ghost locked as resolved and limited conversation to collaborators Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

@elinor-fung elinor-fung elinor-fung approved these changes

Assignees

@AaronRobinsonMSFT AaronRobinsonMSFT

Labels

area-System.Runtime.InteropServices source-generator Indicates an issue with a source generator feature

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

Does the LibraryImportGenerator work for csharp projects only or any?

3 participants

@AaronRobinsonMSFT @elinor-fung @jkoritzinsky