[API Implementation]: Expose StopTheHostException#69404
[API Implementation]: Expose StopTheHostException#69404eerhardt merged 10 commits intodotnet:mainfrom
StopTheHostException#69404Conversation
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/area-extensions-hosting Issue DetailsProposal implementation of #60600 (closes #60600) It took a little longer than planned. Thanks for waiting. Proposalnamespace Microsoft.Extensions.Hosting
{
[Serializable]
public sealed partial class HostAbortedException : Exception
{
public HostAbortedException() { }
private HostAbortedException(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { }
public HostAbortedException(string? message) { }
public HostAbortedException(string? message, System.Exception? innerException) { }
}
}Current state of implementation
/cc @maryamariyan
|
src/libraries/Microsoft.Extensions.Hosting/ref/Microsoft.Extensions.Hosting.cs
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Hosting/src/HostAbortedException.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Hosting/tests/UnitTests/HostAbortedExceptionTests.cs
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Hosting/src/HostAbortedException.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Hosting/tests/UnitTests/HostAbortedExceptionTests.cs
Show resolved
Hide resolved
Co-Authored-By: Eric Erhardt <eric.erhardt@microsoft.com>
|
@maryamariyan Please give a review too 👍🏼 |
src/libraries/Microsoft.Extensions.Hosting/src/Resources/Strings.resx
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.HostFactoryResolver/src/HostFactoryResolver.cs
Show resolved
Hide resolved
|
By the way, is it correct that |
This library is "special" in that it doesn't actually produce a library in the traditional sense. This is a nuget package that contains the That said, this folder still contains a @ViktorHofer - do you happen to know why there is no |
Most probably an unintentional omission in d13863e, which added the library to dotnet/runtime. Feel free to add one. |
Should I do that right along with this PR or would it be better to write an issue for it and do that in a follow up? |
|
No need for an issue, that would be way too much overhead. Just add it to this PR. And don't bother with the version header at the top of the solution file as that will be overwritten anyways, whenever we batch update all solution files. |
src/libraries/Microsoft.Extensions.Hosting/tests/UnitTests/HostAbortedExceptionTests.cs
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Hosting/tests/UnitTests/HostAbortedExceptionTests.cs
Show resolved
Hide resolved
eerhardt
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the contribution.
|
This PR is, I believe, causing problems in dotnet/aspnetcore#41999. We use Microsoft.Extensions.HostFactoryResolver.Sources and it seems src/libraries/Microsoft.Extensions.HostFactoryResolver/src/HostFactoryResolver.cs ended up w/o the necessary reference to Microsoft.Extensions.Hosting in our scenarios. Do we need to react or should we expect a fix in the M.E.HFR.Sources package❔ |
- now need a Microsoft.Extensions.Hosting reference to use Microsoft.Extensions.HostFactoryResolver.Sources
- this was a dead end; waiting instead for a dotnet/runtime fix This reverts commit 62ced99.
[main] Update dependencies from dotnet/efcore dotnet/runtime - Work around dotnet/runtime#69404 break - now need a Microsoft.Extensions.Hosting reference to use Microsoft.Extensions.HostFactoryResolver.Sources - Revert "Work around dotnet/runtime#69404 break" - this was a dead end; waiting instead for a dotnet/runtime fix This reverts commit 62ced99.
…41999) [main] Update dependencies from dotnet/efcore dotnet/runtime - Work around dotnet/runtime#69404 break - now need a Microsoft.Extensions.Hosting reference to use Microsoft.Extensions.HostFactoryResolver.Sources - Revert "Work around dotnet/runtime#69404 break" - this was a dead end; waiting instead for a dotnet/runtime fix This reverts commit 62ced99.
Proposal implementation of #60600 (closes #60600)
It took a little longer than planned. Thanks for waiting.
Proposal
Current state of implementation
/cc @maryamariyan