Expose `LibraryImportAttribute` #66434

elinor-fung · 2022-03-10T05:02:25Z

Expose LibraryImportAttribute in runtime libraries.

Resolves #46822

ghost · 2022-03-10T05:02:29Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost · 2022-03-10T05:02:32Z

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:	elinor-fung
Assignees:	-
Labels:	`area-System.Runtime.InteropServices`
Milestone:	7.0.0

src/libraries/Common/src/System/Runtime/InteropServices/LibraryImportAttribute.cs

src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems

…qualityComparer under CoreLib

...libraries/System.Diagnostics.DiagnosticSource/ref/System.Diagnostics.DiagnosticSource.csproj

...libraries/System.Diagnostics.DiagnosticSource/src/System.Diagnostics.DiagnosticSource.csproj

src/libraries/System.Text.Json/ref/System.Text.Json.csproj

src/libraries/System.Text.Json/src/System.Text.Json.csproj

src/libraries/System.Text.Json/tests/System.Text.Json.Tests/System.Text.Json.Tests.csproj

eng/generators.targets

...ibraries/System.Private.CoreLib/src/System/Runtime/InteropServices/LibraryImportAttribute.cs

src/libraries/System.Runtime.InteropServices/ref/System.Runtime.InteropServices.cs

AaronRobinsonMSFT · 2022-03-10T15:55:26Z

@layomia FYI for JSON source gen changes

...libraries/System.Diagnostics.DiagnosticSource/ref/System.Diagnostics.DiagnosticSource.csproj

Co-authored-by: Jan Kotas <jkotas@microsoft.com> Co-authored-by: Stephen Toub <stoub@microsoft.com>

elinor-fung · 2022-03-11T02:06:35Z

Failures in System.Text.Json.Tests are:

...ibraries/System.Private.CoreLib/src/System/Runtime/InteropServices/LibraryImportAttribute.cs

Co-authored-by: Aaron Robinson <arobins@microsoft.com>

deeprobin

Looks in general good to me.

Are there some tests validating the Attribute properties?

...ibraries/System.Private.CoreLib/src/System/Runtime/InteropServices/LibraryImportAttribute.cs

Expose LibraryImportAttribute

bc65661

elinor-fung added the area-System.Runtime.InteropServices label Mar 10, 2022

elinor-fung added this to the 7.0.0 milestone Mar 10, 2022

ghost added the new-api-needs-documentation label Mar 10, 2022

ghost assigned elinor-fung Mar 10, 2022

jkotas reviewed Mar 10, 2022

View reviewed changes

src/libraries/Common/src/System/Runtime/InteropServices/LibraryImportAttribute.cs Outdated Show resolved Hide resolved

jkotas reviewed Mar 10, 2022

View reviewed changes

src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems Outdated Show resolved Hide resolved

elinor-fung added 2 commits March 9, 2022 21:40

Move under CoreLib and use #if SYSTEM_PRIVATE_CORELIB

569b855

Move IsExternalInit, ExcludeFromCodeCoverageAttribute, and ReferenceE…

3085ad2

…qualityComparer under CoreLib

jkotas reviewed Mar 10, 2022

View reviewed changes

...libraries/System.Diagnostics.DiagnosticSource/ref/System.Diagnostics.DiagnosticSource.csproj Outdated Show resolved Hide resolved

jkotas reviewed Mar 10, 2022

View reviewed changes

...libraries/System.Diagnostics.DiagnosticSource/src/System.Diagnostics.DiagnosticSource.csproj Outdated Show resolved Hide resolved

jkotas reviewed Mar 10, 2022

View reviewed changes

src/libraries/System.Text.Json/ref/System.Text.Json.csproj Outdated Show resolved Hide resolved

jkotas reviewed Mar 10, 2022

View reviewed changes

src/libraries/System.Text.Json/src/System.Text.Json.csproj Outdated Show resolved Hide resolved

jkotas reviewed Mar 10, 2022

View reviewed changes

src/libraries/System.Text.Json/tests/System.Text.Json.Tests/System.Text.Json.Tests.csproj Outdated Show resolved Hide resolved