Skip to content

Return DSA and ECDSA keys from certificate in SignedXml.#55294

Merged
bartonjs merged 2 commits intodotnet:mainfrom
vcsjones:sxml-dsa-ecdsa
Jul 8, 2021
Merged

Return DSA and ECDSA keys from certificate in SignedXml.#55294
bartonjs merged 2 commits intodotnet:mainfrom
vcsjones:sxml-dsa-ecdsa

Conversation

@vcsjones
Copy link
Member

@vcsjones vcsjones commented Jul 7, 2021

If the X.509 certificate has a DSA or ECDSA public key, return them if they are available.

Closes #55194

I was able to add a test case for DSA, prior to the fix the test fails with:

 Error Message:
   System.ArgumentNullException : Value cannot be null. (Parameter 'key')
  Stack Trace:
     at System.Security.Cryptography.Xml.SignedXml.CheckSignedInfo(AsymmetricAlgorithm key) in /workspaces/runtime/src/libraries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/SignedXml.cs:line 998
   at System.Security.Cryptography.Xml.SignedXml.CheckSignature(AsymmetricAlgorithm key) in /workspaces/runtime/src/libraries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/SignedXml.cs:line 283

@vcsjones
Return DSA and ECDSA keys from certificate.
69e8e69 
If the X.509 certificate has a DSA or ECDSA public key, return them if
they are available.
@ghost ghost added the area-System.Security label Jul 7, 2021
@ghost
Copy link

ghost commented Jul 7, 2021

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks
See info in area-owners.md if you want to be subscribed.

Issue Details

If the X.509 certificate has a DSA or ECDSA public key, return them if they are available.

Closes #55194

I was able to add a test case for DSA, prior to the fix the test fails with:

 Error Message:
   System.ArgumentNullException : Value cannot be null. (Parameter 'key')
  Stack Trace:
     at System.Security.Cryptography.Xml.SignedXml.CheckSignedInfo(AsymmetricAlgorithm key) in /workspaces/runtime/src/libraries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/SignedXml.cs:line 998
   at System.Security.Cryptography.Xml.SignedXml.CheckSignature(AsymmetricAlgorithm key) in /workspaces/runtime/src/libraries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/SignedXml.cs:line 283
Author: vcsjones
Assignees: -
Labels:

area-System.Security
Milestone: -

@vcsjones
Copy link
Member Author

vcsjones commented Jul 7, 2021

My Windows box is currently sitting in pieces behind me for a few days, so waiting to see what CI says about .NET Framework before I mark as reviewable.

@vcsjones vcsjones changed the title Return DSA and ECDSA keys from certificate. Return DSA and ECDSA keys from certificate in SignedXml. Jul 7, 2021
bartonjs
bartonjs approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@bartonjs bartonjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, provided CI agrees.

@vcsjones vcsjones marked this pull request as ready for review July 8, 2021 01:53
@runfoapp runfoapp bot mentioned this pull request Jul 8, 2021
Closed
@vcsjones
Copy link
Member Author

vcsjones commented Jul 8, 2021

Considering the previous run was all green and the only thing that was added in the second commit is a comment, I would think the failures are unrelated.

@bartonjs bartonjs merged commit cbf4020 into dotnet:main Jul 8, 2021
@vcsjones vcsjones deleted the sxml-dsa-ecdsa branch July 8, 2021 16:52
@ghost ghost locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bartonjs bartonjs bartonjs approved these changes

+1 more reviewer

@filipnavara filipnavara filipnavara approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.Security

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

System.Security.Cryptography.Xml.Utils.GetAnyPublicKey returns only RSA or null?

3 participants

@vcsjones @filipnavara @bartonjs