Handle Counter Polling Interval of 0#53836
Merged
josalem merged 4 commits intodotnet:mainfrom Jun 10, 2021
Merged
Conversation
* default internal state to DateTime.MaxValue * re-check IsEnabled after not holding lock * add test for setting interval to 0
|
Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti Issue DetailsFixes #53564
This will need to be backported to 3.1 and 5.0. CC @tommcdon
|
noahfalk
requested changes
Jun 8, 2021
Member
noahfalk
left a comment
There was a problem hiding this comment.
I'm hoping we can go even more targetted, suggestion inline : )
Member
|
Looks like I managed to repro/investigate/fix this issue when testing on iOS in parallel to this fix/investigation, #53887. |
stephentoub
reviewed
Jun 9, 2021
src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/CounterGroup.cs
Outdated
Show resolved
Hide resolved
This was referenced Jun 9, 2021
Contributor
Author
|
\backport to release/5.0 |
Member
|
/backport to release/5.0 |
Contributor
|
Started backporting to release/5.0: https://github.com/dotnet/runtime/actions/runs/926712176 |
josalem
pushed a commit
to josalem/coreclr
that referenced
this pull request
Jun 10, 2021
jeffschwMSFT
pushed a commit
to dotnet/coreclr
that referenced
this pull request
Jun 15, 2021
* Backport dotnet/runtime#53836 * Fix test build * update test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53564
This will need to be backported to 3.1 and 5.0.
CC @tommcdon