Add SystemNative_LowLevelMonitor_TimedWait to System.Native#47325
Add SystemNative_LowLevelMonitor_TimedWait to System.Native#47325CoffeeFlux merged 6 commits intodotnet:masterfrom
Conversation
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFirst of 3 PRs. The second will be adding some of the managed Threading implementations from NativeAOT, and the third will modify them, wire them up to the Mono build, and implement the necessary Mono-specific changes.
|
|
This PR reminds me—we should really start differentiating between I know historically there was interest in just using |
|
The current iOS/tvOS failures are due to This is probably overkill nowadays, but the difference is worth noting. I'll add a check for |
ed52969 to
d8a0fed
Compare
|
I think this logic should work, unless I'm misremembering and these are broken at runtime on iOS as opposed to unavailable. |
Depends on dotnet/runtime#47325 and dotnet/runtime#47327, draft until they're in and I rebase this. Fixes dotnet/runtime#44795 Best reviewed commit by commit—the commits starting with "Remote appropriate icalls from Mono" are new. In some cases, I've left comments in the commit description. I expect the most interesting commits to be the last few, in particular the annotations.
|
Still does not build... |
d8a0fed to
b2f00ac
Compare
|
Yeah, I forgot that in System.Native we use |
|
It's not clear to me why this is breaking the CoreCLR desktop builds but not the Mono ones... Is CoreCLR using the System.Native CMake stuff in a way I'm not familiar with? Build error it's hitting is here runtime/src/coreclr/gc/unix/events.cpp Line 143 in 69e114c |
|
I suspect that it is because |
|
It may have something to do with |
b2f00ac to
44d3c2e
Compare
44d3c2e to
086cbae
Compare
fc351e8 to
b13b6f4
Compare
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
First of 3 PRs.
The second will be adding some of the managed Threading implementations from NativeAOT, and the third will modify them, wire them up to the Mono build, and implement the necessary Mono-specific changes.