Fix format of JIT-EE version GUID#46116
Merged
jkotas merged 1 commit intodotnet:masterfrom Dec 16, 2020
Merged
Conversation
Contributor
Author
|
This fixes the superpmi.py parsing of this GUID comment string. I could generalize the parsing in superpmi.py, but then someone might change it again. Yes, this will kick off another SuperPMI collection for the same GUID. cc @dotnet/jit-contrib |
AndyAyersMS
approved these changes
Dec 16, 2020
kunalspathak
approved these changes
Dec 16, 2020
BruceForstall
added a commit
to BruceForstall/runtime
that referenced
this pull request
Jan 8, 2021
With dotnet#46116, a copy of the actual first line of the GUID definition was added as a comment. Unfortunately, the superpmi.py GUID parser was finding that one instead of the actual GUID. Fix the parser to match from the beginning of the line.
BruceForstall
added a commit
that referenced
this pull request
Jan 9, 2021
With #46116, a copy of the actual first line of the GUID definition was added as a comment. Unfortunately, the superpmi.py GUID parser was finding that one instead of the actual GUID. Fix the parser to match from the beginning of the line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.