Skip to content

[Mono] enable tests that seem to pass#43407

Merged
lambdageek merged 2 commits intodotnet:masterfrom
lambdageek:try-run-active-issues
Jan 7, 2021
Merged

[Mono] enable tests that seem to pass#43407
lambdageek merged 2 commits intodotnet:masterfrom
lambdageek:try-run-active-issues

Conversation

@lambdageek
Copy link
Member

@lambdageek lambdageek commented Oct 14, 2020 •
edited
Loading

These tests haveActiveIssue attributes that link to https://github.com/mono/mono issues. They appear to pass now.

Test project Issue
System.Numerics.Vectors Fixes mono/mono#15190
System.ComponentModel.Composition Possibly addresses mono/mono#16417
System.Private.Xml Fixes mono/mono#15353
System.Linq.Parallel Fixes mono/mono#14956

Note there are a number of remaining ActiveIssue attributes that link to issues in mono/mono see gist https://gist.github.com/lambdageek/dd9b7872d446a16589529f0c562c4123

@lambdageek
Copy link
Member Author

lambdageek commented Oct 14, 2020

/cc @steveisok

@lambdageek lambdageek added runtime-mono specific to the Mono runtime area-Build-mono disabled-test The test is disabled in source code against the issue labels Oct 14, 2020
@lambdageek
Copy link
Member Author

lambdageek commented Oct 14, 2020

The ComponentModel tests with mono/mono#16417 are reportedly flaky. So perhaps those are still active.

@lambdageek
Copy link
Member Author

lambdageek commented Oct 14, 2020 •
edited
Loading

The Build Browser wasm Release AllSubsets_Mono failure is interesting
https://helix.dot.net/api/2019-06-17/jobs/e88282f0-b8c9-45e2-89de-e95b11b28f8f/workitems/System.ComponentModel.Composition.Tests/console :

[19:37:41] info: Discovering: System.ComponentModel.Composition.Tests.dll (method display = ClassAndMethod, method display options = None)
[19:37:44] info: Discovered:  System.ComponentModel.Composition.Tests.dll (found 1424 of 1588 test cases)
[19:37:44] info: Starting:    System.ComponentModel.Composition.Tests.dll
[19:37:47] fail: [FAIL] System.ComponentModel.Composition.DirectoryCatalogTests.LoadedFiles_ContainsMultipleDllsAndSomeNonDll_ShouldOnlyContainDlls
[19:37:47] info: System.ArgumentException : Empty file name is not legal. (Parameter 'sourceFileName')
[19:37:47] info:    at System.IO.File.Copy(String sourceFileName, String destFileName, Boolean overwrite)
[19:37:47] info:    at System.IO.File.Copy(String sourceFileName, String destFileName)
[19:37:47] info:    at System.ComponentModel.Composition.DirectoryCatalogTests.LoadedFiles_ContainsMultipleDllsAndSomeNonDll_ShouldOnlyContainDlls()
[19:37:47] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
[19:37:48] fail: [FAIL] System.ComponentModel.Composition.Primitives.DirectoryCatalogDebuggerProxyTests.LoadedFiles_ContainsMultipleDllsAndSomeNonDll_ShouldOnlyContainDlls
[19:37:48] info: System.ArgumentException : Empty file name is not legal. (Parameter 'sourceFileName')
[19:37:48] info:    at System.IO.File.Copy(String sourceFileName, String destFileName, Boolean overwrite)
[19:37:48] info:    at System.IO.File.Copy(String sourceFileName, String destFileName)
[19:37:48] info:    at System.ComponentModel.Composition.Primitives.DirectoryCatalogDebuggerProxyTests.LoadedFiles_ContainsMultipleDllsAndSomeNonDll_ShouldOnlyContainDlls()
[19:37:48] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
[19:37:49] fail: [FAIL] Tests.Integration.DiscoveryTests.InheritedExport_TwoInterfaces
[19:37:49] info: Assert.Equal() Failure
[19:37:49] info: Expected: String[] ["IFoo1", "IFoo2"]
[19:37:49] info: Actual:   SelectArrayIterator<Lazy<Object, IDictionary<String, Object>>, String> ["IFoo2", "IFoo1"]
[19:37:49] info:    at Tests.Integration.DiscoveryTests.InheritedExport_TwoInterfaces()
[19:37:49] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
[19:37:50] info: Finished:    System.ComponentModel.Composition.Tests.dll
[19:37:50] info: 
[19:37:50] info: === TEST EXECUTION SUMMARY ===
[19:37:50] info: Total: 1424, Errors: 0, Failed: 3, Skipped: 1, Time: 5.776298s
[19:37:50] info:

The two test doing copying should probably be disabled on wasm.

The test InheritedExport_TwoInterfaces also fails on (Libraries Test Run release mono Linux arm64 Debug) so that seems like a test that doesn't pass on Mono yet.

@runfoapp runfoapp bot mentioned this pull request Oct 14, 2020
Closed
@marek-safar marek-safar requested a review from SamMonoRT January 5, 2021 21:21
@SamMonoRT SamMonoRT requested a review from steveisok January 5, 2021 21:28
@steveisok
Copy link
Member

steveisok commented Jan 5, 2021

@lambdageek Can you push again to restart the build?

@lambdageek lambdageek force-pushed the try-run-active-issues branch from ee68c35 to 8dbc583 Compare January 6, 2021 15:06
@lambdageek
Copy link
Member Author

lambdageek commented Jan 6, 2021

rebased on master

@lambdageek lambdageek force-pushed the try-run-active-issues branch from 8dbc583 to a115046 Compare January 6, 2021 16:33
@lambdageek
Re-enable some passing tests for Mono
4a71dd5 
That have active issues in mono/mono
@lambdageek lambdageek force-pushed the try-run-active-issues branch from a115046 to 4a71dd5 Compare January 6, 2021 16:36
@lambdageek lambdageek merged commit 1cd5e42 into dotnet:master Jan 7, 2021
am11
am11 reviewed Jan 7, 2021
View reviewed changes
@lambdageek lambdageek mentioned this pull request Jan 7, 2021
Merged
lambdageek added a commit to lambdageek/runtime that referenced this pull request Jan 8, 2021
@lambdageek
Remove incorrectly added ActiveIssue
a84325a 
mono/mono#15029 was fixed by
dotnet#44081, but
dotnet#43407 incorrectly re-added the ActiveIssue.
lambdageek added a commit that referenced this pull request Jan 8, 2021
@lambdageek
Remove incorrectly added ActiveIssue (#46680)
17dd7c6 
mono/mono#15029 was fixed by
#44081, but
#43407 incorrectly re-added the ActiveIssue.
@ghost ghost locked as resolved and limited conversation to collaborators Feb 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@steveisok steveisok steveisok approved these changes

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

+1 more reviewer

@am11 am11 am11 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Build-mono disabled-test The test is disabled in source code against the issue runtime-mono specific to the Mono runtime

Projects

None yet

Milestone

No milestone

3 participants

@lambdageek @steveisok @am11