Disable EOL Target Frameworks check in newer SDKs#40552
Merged
safern merged 1 commit intodotnet:masterfrom Aug 8, 2020
Merged
Conversation
Collaborator
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Member
Author
|
This was added 17 days ago into the SDK: |
jkoritzinsky
approved these changes
Aug 7, 2020
Member
|
Should we continue building assets for EOL targets or harvest them instead? cc @ericstj |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With recent SDKs (rc1) EOL checks were enabled for nca3.0 and nca2.0... we still build for those tfms in some libraries that support those frameworks via NuGet packages. Disable that check to unblock developers that get that SDK globally installed via latest VS Internal Preview.
cc: @dotnet/runtime-infrastructure