Disable GCStress for profiler tests#40171
Merged
davmason merged 3 commits intodotnet:masterfrom Jul 31, 2020
Merged
Conversation
|
Tagging subscribers to this area: @tommcdon |
jashook
approved these changes
Jul 31, 2020
Contributor
|
/cc @dotnet/jit-contrib |
BruceForstall
approved these changes
Jul 31, 2020
Contributor
BruceForstall
left a comment
There was a problem hiding this comment.
It's generally helpful to leave a comment in the project files to indicate why a test is disabled for GCStress, so when you go back later you understand that it is a permanent thing because of true incompatibility, never fixing an issue, too slow, etc.
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a set of profiler tests either running in to an existing product bug exacerbated by GCStress, or they cause a lot of GCs and shouldn't be run under GCStress because they will take forever and are uninteresting test cases.
Fixes #39931
Fixes #39682
Fixes #35884