Skip to content

Conversation

@ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Jul 29, 2020

Fixes #38878

  • ExceptionAssert -> AssertExtensions
  • ThreadReplacer -> ThreadCultureChange
  • TaskTimeoutExtensions -> TaskExtensions
  • etc...

@ViktorHofer ViktorHofer requested a review from maryamariyan July 29, 2020 17:34
@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ViktorHofer ViktorHofer requested a review from ericstj July 29, 2020 19:19
@ViktorHofer ViktorHofer force-pushed the RemoveAspNetCoreTesting branch from 175ae9a to 4e0b197 Compare July 29, 2020 19:19
@ericstj ericstj requested a review from JunTaoLuo July 29, 2020 20:19
@ViktorHofer
Copy link
Member Author

@JunTaoLuo @maryamariyan @ericstj kindly asking for a review. This deletes all the aspnetcore infra that we ported over as well as it isn't used and replaced the few callers that used some of the features with runtime helpers.

@ericstj ericstj removed their request for review July 30, 2020 15:43
@ericstj
Copy link
Member

ericstj commented Jul 30, 2020

@maryamariyan and @JunTaoLuo will need to review this one. I thought we had eliminated all dead code, so removing this might be removing something they need.

@maryamariyan
Copy link
Contributor

I thought we had eliminated all dead code, so removing this might be removing something they need.

@ericstj this work item is tracked in issue #37821 (comment), second item under code cleanup.

@ViktorHofer
Copy link
Member Author

That was all dead code, so no worries.

@JunTaoLuo
Copy link
Contributor

Yea we were sort of expecting some of the Testing Infra to be unused. Some of the functionality have analogous counterparts in dotnet/runtime and some of the infra was created to support AspNetCore builds. I took a brief look and the removed code looks reasonable.

Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup remaining usages of FrameworkSkipCondition

7 participants