Skip to content

Fix unwind info decoding #40030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cshung merged 1 commit into from
Jul 29, 2020
Merged

Fix unwind info decoding #40030

cshung merged 1 commit into from
Jul 29, 2020

Conversation

@cshung
Copy link
Contributor

@cshung cshung commented Jul 28, 2020

Fixes #39940

@cshung cshung added the area-R2RDump-coreclr Ready-to-run image dump tool label Jul 28, 2020
@cshung cshung requested a review from trylek July 28, 2020 18:36
@cshung cshung mentioned this pull request Jul 29, 2020
Merged
@cshung cshung force-pushed the public/dev/andrewau/fix-unwind-info-decoding branch from 8348e8f to e03576e Compare July 29, 2020 14:56
trylek
trylek approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!

@cshung cshung merged commit 251a3c3 into dotnet:master Jul 29, 2020
@cshung cshung deleted the public/dev/andrewau/fix-unwind-info-decoding branch July 29, 2020 19:21
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@cshung @Jacksondr5
Fix unwind info decoding (dotnet#40030)
950a039
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@trylek trylek trylek approved these changes

Assignees

No one assigned

Labels

area-R2RDump-coreclr Ready-to-run image dump tool

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

R2RDump Unwind code decoding logic missed the extra word or dword in the UWOP_ALLOC_LARGE case.

3 participants

@cshung @trylek @karelz