Skip to content

Add Unsafe.IsNullRef and Unsafe.NullRef #40008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GrabYourPitchforks merged 8 commits into from
Jul 29, 2020
Merged

Add Unsafe.IsNullRef and Unsafe.NullRef #40008

GrabYourPitchforks merged 8 commits into from
Jul 29, 2020

Conversation

@Sergio0694
Copy link
Contributor

@Sergio0694 Sergio0694 commented Jul 28, 2020

Closes #31170

This PR adds the following new APIs to the public Unsafe class:

namespace System.Runtime.CompilerServices
{
    public class Unsafe
    {
        public static bool IsNullRef<T>(ref T);
        public static ref T NullRef<T>();
    }
}

cc. @jkotas @GrabYourPitchforks @stephentoub

@Dotnet-GitSync-Bot
Copy link
Collaborator

Dotnet-GitSync-Bot commented Jul 28, 2020

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@Dotnet-GitSync-Bot
Copy link
Collaborator

Dotnet-GitSync-Bot commented Jul 28, 2020

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@Sergio0694 Sergio0694 mentioned this pull request Jul 28, 2020
Closed
@Sergio0694 @am11
Fixed a refactoring issue
1e4f670 
Co-authored-by: Adeel Mujahid <adeelbm@outlook.com>
jkotas
jkotas approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Sergio0694
Copy link
Contributor Author

Sergio0694 commented Jul 28, 2020

Happy to help! Looking forward to the public release with these new APIs! 😊🎉

@GrabYourPitchforks
Copy link
Member

GrabYourPitchforks commented Jul 28, 2020

@jkotas @marek-safar Any idea why the mono tests might be segfaulting?

@marek-safar
Copy link
Contributor

marek-safar commented Jul 28, 2020

It looks like it's hitting some corner case in interpreter implementation. @vargaz could you look into that while @BrzVlad is away?

@vargaz vargaz mentioned this pull request Jul 28, 2020
Merged
@GrabYourPitchforks
Copy link
Member

GrabYourPitchforks commented Jul 28, 2020

Looks like Jan already beat me to spinning CI back up. ;)

@GrabYourPitchforks GrabYourPitchforks merged commit e671f57 into dotnet:master Jul 29, 2020
@Sergio0694 Sergio0694 deleted the feature/unsafe-isnullref-nullref branch July 29, 2020 08:14
ltrzesniewski added a commit to ltrzesniewski/InlineIL.Fody that referenced this pull request Aug 3, 2020
@ltrzesniewski
Add IsNullRef and NullRef to Unsafe example
5484cbd 
dotnet/runtime#40008
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@Sergio0694 @am11
@jkotas @Jacksondr5
Add Unsafe.IsNullRef and Unsafe.NullRef (dotnet#40008)
86088b2 
Co-authored-by: Adeel Mujahid <adeelbm@outlook.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@Sergio0694 Sergio0694 mentioned this pull request Sep 28, 2020
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@GrabYourPitchforks GrabYourPitchforks GrabYourPitchforks approved these changes

@jkotas jkotas jkotas approved these changes

+1 more reviewer

@am11 am11 am11 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.Runtime.CompilerServices new-api-needs-documentation

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

API proposal: Unsafe.NullRef, IsNullRef

7 participants

@Sergio0694 @Dotnet-GitSync-Bot @GrabYourPitchforks @marek-safar @am11 @jkotas @karelz