Skip to content

Fix mdarrays #39984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davidwrighton merged 4 commits into from
Jul 28, 2020
Merged

Fix mdarrays #39984

davidwrighton merged 4 commits into from
Jul 28, 2020

Conversation

@davidwrighton
Copy link
Member

@davidwrighton davidwrighton commented Jul 28, 2020

  • MDArrays are special and method references to the methods needs to be encoded with their type in more cases than normal methods
  • Only generate the owner type if the memberref does not encode the same owner type
  • Add tests for various multidimensional array scenarios to crossgen2smoke

Fix issue #38260

@davidwrighton
Fix Multidimensional array method behavior in crossgen2
9940012 
- MDArrays are special and method references to the methods needs to be encoded with their type
- Only generate the owner type if the memberref does not encode the same owner type
@davidwrighton
Update issues.targets
9016f42
@davidwrighton
Merge branch 'master' of github.com:dotnet/runtime into fix_mdarrays
cb3e2a1
@davidwrighton davidwrighton requested a review from trylek July 28, 2020 01:44
@davidwrighton
Copy link
Member Author

davidwrighton commented Jul 28, 2020

@dotnet/crossgen-contrib

@davidwrighton davidwrighton linked an issue Jul 28, 2020 that may be closed by this pull request
CG2: Test failure JIT\Generics\Arrays\TypeParameters\MultiDim\class01 and struct01 #38260
Closed
AntonLapounov
AntonLapounov reviewed Jul 28, 2020
View reviewed changes
src/tests/readytorun/crossgen2/Program.cs Outdated
public override int GetHashCode() { return x; }
}

struct SomeClass : IEquatable<SomeClass>
Copy link
Member

@AntonLapounov AntonLapounov Jul 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be class?

AntonLapounov
AntonLapounov reviewed Jul 28, 2020
View reviewed changes
@davidwrighton davidwrighton merged commit 36f0c48 into dotnet:master Jul 28, 2020
@davidwrighton davidwrighton mentioned this pull request Jul 28, 2020
Merged
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@davidwrighton @Jacksondr5
Fix mdarrays (dotnet#39984)
4115085 
- MDArrays are special and method references to the methods needs to be encoded with their type in more cases than normal methods
- Only generate the owner type if the memberref does not encode the same owner type
- Add tests for various multidimensional array scenarios to crossgen2smoke

Fix issue dotnet#38260
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
@davidwrighton davidwrighton deleted the fix_mdarrays branch April 20, 2021 17:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AntonLapounov AntonLapounov AntonLapounov approved these changes

@trylek trylek Awaiting requested review from trylek

Assignees

No one assigned

Labels

area-crossgen2-coreclr

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

CG2: Test failure JIT\Generics\Arrays\TypeParameters\MultiDim\class01 and struct01

4 participants

@davidwrighton @AntonLapounov @karelz @Dotnet-GitSync-Bot