Skip to content

Add rules for changing InstructionSetDesc.txt#39777

Merged
jkotas merged 1 commit intodotnet:masterfrom
jkotas:instructionsetdesc-note
Jul 22, 2020
Merged

Add rules for changing InstructionSetDesc.txt#39777
jkotas merged 1 commit intodotnet:masterfrom
jkotas:instructionsetdesc-note

Conversation

@jkotas
Copy link
Member

@jkotas jkotas commented Jul 22, 2020

No description provided.

@Dotnet-GitSync-Bot
Copy link
Collaborator

Dotnet-GitSync-Bot commented Jul 22, 2020

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@jkotas jkotas mentioned this pull request Jul 22, 2020
Merged
@jkotas jkotas requested a review from davidwrighton July 22, 2020 14:05
@jkotas
Copy link
Member Author

jkotas commented Jul 22, 2020

cc @tannergooding @MichalStrehovsky

@ghost
Copy link

ghost commented Jul 22, 2020

Tagging subscribers to this area: @tannergooding
Notify danmosemsft if you want to be subscribed.

tannergooding
tannergooding approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@tannergooding tannergooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

It might be nice to just have https://github.com/dotnet/runtime/blob/0d5b3623852b2f0ec81721e486a68fb50e301571/src/coreclr/src/tools/Common/JitInterface/ThunkGenerator/Program.cs insert a new random Guid as part of the update.

@tannergooding
Copy link
Member

tannergooding commented Jul 22, 2020

Just confirming, some other change already updated the JIT/EE GUID, right?

@jkotas
Copy link
Member Author

jkotas commented Jul 22, 2020

Just confirming, some other change already updated the JIT/EE GUID, right?

I do not think so. @MichalStrehovsky tried to update RyuJIT in CoreRT repo last night (dotnet/corert#8242) and it failed hard way, not with the nice JIT/EE interface needs an update error.

@tannergooding
Copy link
Member

tannergooding commented Jul 22, 2020

I'll get a change up in a new PR

@tannergooding tannergooding mentioned this pull request Jul 22, 2020
Merged
@jkotas jkotas merged commit 1616d2e into dotnet:master Jul 22, 2020
@jkotas jkotas deleted the instructionsetdesc-note branch July 26, 2020 00:52
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@jkotas @Jacksondr5
Add rules for changing InstructionSetDesc.txt (dotnet#39777)
11bfd6b
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tannergooding tannergooding tannergooding approved these changes

@davidwrighton davidwrighton Awaiting requested review from davidwrighton

Assignees

No one assigned

Labels

area-System.Runtime.Intrinsics

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jkotas @Dotnet-GitSync-Bot @tannergooding @karelz