Fix sync ConnectHelper.Connect#39514
Merged
ManickaP merged 1 commit intodotnet:masterfrom Jul 20, 2020
Merged
Conversation
|
Tagging subscribers to this area: @dotnet/ncl |
ea27970 to
1d4d9d0
Compare
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
ManickaP
added a commit
to ManickaP/runtime
that referenced
this pull request
Aug 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During synchronous creation of a new
NetworkStream, theSocket.Connectpassed successfully and then cancellation disposed the socket. ThenNetworkStreamctor checked the socket state and thrown anIOException. This exception should have been handled the same way as exceptions fromConnectand mapped toOperationCanceledException.Fixes #39279