Skip to content

Use ConditionalFact/Theory for skipping RemoteExecutor on unsupported platforms #37479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akoeplinger merged 4 commits into from
Jun 9, 2020
Merged

Use ConditionalFact/Theory for skipping RemoteExecutor on unsupported platforms #37479

akoeplinger merged 4 commits into from
Jun 9, 2020

Conversation

@akoeplinger
Copy link
Member

@akoeplinger akoeplinger commented Jun 5, 2020

RemoteExecutor doesn't work on platforms that can't spawn processes like iOS/Android/WebAssembly.

@ghost
Copy link

ghost commented Jun 5, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@akoeplinger akoeplinger force-pushed the remoteexecutor-conditional branch 3 times, most recently from 6cabed3 to 674bb52 Compare June 5, 2020 11:15
@stephentoub
Copy link
Member

stephentoub commented Jun 5, 2020

I thought we were exploring ways to do this without annotating all tests that use it. Did that turn out not to be possible?

@akoeplinger akoeplinger force-pushed the remoteexecutor-conditional branch 2 times, most recently from bec1b74 to 569d487 Compare June 5, 2020 11:19
@akoeplinger
Copy link
Member Author

akoeplinger commented Jun 5, 2020

@stephentoub yes it turned out to be impossible

@akoeplinger akoeplinger marked this pull request as ready for review June 5, 2020 11:23
@stephentoub
Copy link
Member

stephentoub commented Jun 5, 2020

Ok, thanks

@akoeplinger akoeplinger requested a review from safern June 5, 2020 11:23
@akoeplinger
Use ConditionalFact/Theory for skipping RemoteExecutor on unsupported…
668bc6a 
… platforms

RemoteExecutor doesn't work on platforms that can't spawn processes like iOS/Android/WebAssembly.
@akoeplinger akoeplinger force-pushed the remoteexecutor-conditional branch from 569d487 to 668bc6a Compare June 5, 2020 11:50
stephentoub
stephentoub approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

safern
safern approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@akoeplinger
Merge remote-tracking branch 'upstream/master' into remoteexecutor-co…
9fd88d8 
…nditional

# Conflicts:
#	src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs
@akoeplinger
Merge remote-tracking branch 'upstream/master' into remoteexecutor-co…
19fb9b1 
…nditional

# Conflicts:
#	src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs
@akoeplinger
Copy link
Member Author

akoeplinger commented Jun 9, 2020

Failures are #37635 and #36488

@akoeplinger akoeplinger merged commit da10ba8 into dotnet:master Jun 9, 2020
@akoeplinger akoeplinger deleted the remoteexecutor-conditional branch June 9, 2020 10:40
@jaredpar jaredpar mentioned this pull request Jun 9, 2020
Closed
@akoeplinger akoeplinger mentioned this pull request Jun 16, 2020
Merged
akoeplinger added a commit that referenced this pull request Jun 17, 2020
@akoeplinger
Disable two more tests that use RemoteExecutor on platforms where it'…
076d5fa 
…s not supported (#37992)

Those sneaked in with #37528 which was merged at the same time as my PR #37479.
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@safern safern safern approved these changes

@stephentoub stephentoub stephentoub approved these changes

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees

No one assigned

Labels

area-Meta

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@akoeplinger @stephentoub @ViktorHofer @safern @danmoseley @Dotnet-GitSync-Bot