Improve System.Numerics.Matrix3x2 and Matrix4x4 hash codes#34452
Merged
danmoseley merged 3 commits intodotnet:masterfrom Aug 12, 2020
Merged
Improve System.Numerics.Matrix3x2 and Matrix4x4 hash codes#34452danmoseley merged 3 commits intodotnet:masterfrom
danmoseley merged 3 commits intodotnet:masterfrom
Conversation
src/libraries/System.Private.CoreLib/src/System/Numerics/Matrix4x4.cs
Outdated
Show resolved
Hide resolved
Member
|
Thanks so much for the contribution! This looks good overall and I just had one piece of feedback. |
tannergooding
approved these changes
Apr 2, 2020
Member
tannergooding
left a comment
There was a problem hiding this comment.
LGTM. I've tagged @pgovind for review as well
gfoidl
reviewed
Apr 2, 2020
src/libraries/System.Private.CoreLib/src/System/Numerics/Matrix3x2.cs
Outdated
Show resolved
Hide resolved
Member
|
@tannergooding looks like we can hit merge on this one, right? Or should we rerun CI at this point? Seems it got lost in the shuffle. |
Member
|
I'll rerun CI and apply the auto-merge label. |
|
Hello @tannergooding! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Member
|
Failing leg seems defunct now |
Member
|
Thanks @Marusyk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used
System.HashCodetype to construct the final hashFixes #20308
Please review
Thank you in advance