-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Closed
Labels
area-System.NumericsenhancementProduct code improvement that does NOT require public API changes/additionsProduct code improvement that does NOT require public API changes/additionshelp wanted[up-for-grabs] Good issue for external contributors[up-for-grabs] Good issue for external contributors
Milestone
Description
Currently, the fields' hash codes are simply added: https://github.com/dotnet/corefx/blob/master/src/System.Numerics.Vectors/src/System/Numerics/Matrix4x4.cs#L2209-L2212, https://github.com/dotnet/corefx/blob/master/src/System.Numerics.Vectors/src/System/Numerics/Matrix3x2.cs#L805-L807. It seems like it would be better to change this to use HashHelpers.Combine().
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area-System.NumericsenhancementProduct code improvement that does NOT require public API changes/additionsProduct code improvement that does NOT require public API changes/additionshelp wanted[up-for-grabs] Good issue for external contributors[up-for-grabs] Good issue for external contributors