Delete lock accounting#33048
Merged
jkotas merged 1 commit intodotnet:masterfrom Mar 2, 2020
jkotas:lock-accounting
Merged
Conversation
This is left-over from CLR SQL support. We do not need it in CoreCLR.
stephentoub
approved these changes
Mar 2, 2020
Merged
Member
Author
|
Failure is #32805 |
danmoseley
reviewed
Mar 2, 2020
| AppDomain *pDomain = GetAppDomain(); | ||
| // Cannot enable the following assertion. | ||
| // We may take the lock, but the lock will be released during exception backout. | ||
| //_ASSERTE(!pDomain->IsDefaultDomain()); |
Member
There was a problem hiding this comment.
Everything's the default domain now right?
Member
Author
There was a problem hiding this comment.
Yes, that is more code that can be deleted #33073
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is left-over from CLR SQL support. We do not need it in CoreCLR.