Delete AppDomain::IsDefaultDomain#33073
Merged
jkotas merged 2 commits intodotnet:masterfrom Mar 3, 2020
jkotas:default-domain
Merged
Delete AppDomain::IsDefaultDomain#33073jkotas merged 2 commits intodotnet:masterfrom jkotas:default-domain
jkotas merged 2 commits intodotnet:masterfrom
jkotas:default-domain
Conversation
danmoseley
reviewed
Mar 2, 2020
| } | ||
| // If this assert fires, then it likely means the target is corrupted. | ||
| TargetConsistencyCheck(m_pDefaultAppDomain == NULL); | ||
| m_pDefaultAppDomain = pAppDomain; |
Member
There was a problem hiding this comment.
m_pDefaultAppDomain could be renamed?
Member
Author
There was a problem hiding this comment.
I think this name is ok. Many other names (including APIs) and comments talk about default appdomain too.
danmoseley
approved these changes
Mar 2, 2020
elinor-fung
reviewed
Mar 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.