Remove references to gender by drewnoakes · Pull Request #262 · dotnet/runtime

drewnoakes · 2019-11-26T02:54:54Z

This PR:

removes assumptions of gender where it is unknown or irrelevant
recognises non-binary gender

In many instances this is achieved through the use of the singular they pronoun and related forms.

scalablecory

Looks good to me. Thanks for the PR. I wonder if dotnet/dotnet-api-docs could use a similar treatment.

ViktorHofer · 2019-11-26T14:33:06Z

Thanks a lot Drew

stephentoub · 2019-11-26T14:31:56Z

docs/coding-guidelines/clr-code-guide.md

 If you need to coordinate with unmanaged code, or if you need to do WaitForMultipleHandles ANY/ALL, you will have to avoid WszCreateEvent. If you really know what you are doing, go directly to the OS to obtain these handles. Everyone else should seek advice from someone who thoroughly understands the implications to our host. Obviously the general rule is that everyone should go through our hosted abstraction.

-Sometimes you might find yourself building the equivalent of a critical section, but using an event directly. The problem here is that we cannot identify the thread that owns the lock, because the owner isn't identified until he "leaves'" the lock by calling SetEvent or Pulse. Consider whether a Crst might be more appropriate.
+Sometimes you might find yourself building the equivalent of a critical section, but using an event directly. The problem here is that we cannot identify the thread that owns the lock, because the owner isn't identified until they "leave'" the lock by calling SetEvent or Pulse. Consider whether a Crst might be more appropriate.


Suggested change

Sometimes you might find yourself building the equivalent of a critical section, but using an event directly. The problem here is that we cannot identify the thread that owns the lock, because the owner isn't identified until they "leave'" the lock by calling SetEvent or Pulse. Consider whether a Crst might be more appropriate.

Sometimes you might find yourself building the equivalent of a critical section, but using an event directly. The problem here is that we cannot identify the thread that owns the lock, because the owner isn't identified until they "leave" the lock by calling SetEvent or Pulse. Consider whether a Crst might be more appropriate.

stephentoub · 2019-11-26T14:32:45Z

src/coreclr/src/debug/di/rsstackwalk.cpp

            // We populate the code for ReJit eagerly to make sure we still have it if the profiler removes the
-            // instrumentation later. Of course the only way it will still be accessible to our caller is if he
-            // saves a pointer to the ILCode.
+            // instrumentation later. Of course the only way it will still be accessible to our caller is if they


Suggested change

// instrumentation later. Of course the only way it will still be accessible to our caller is if they

// instrumentation later. Of course the only way it will still be accessible to our caller is if it

stephentoub · 2019-11-26T14:32:53Z

src/coreclr/src/debug/di/rsstackwalk.cpp

-            // instrumentation later. Of course the only way it will still be accessible to our caller is if he
-            // saves a pointer to the ILCode.
+            // instrumentation later. Of course the only way it will still be accessible to our caller is if they
+            // save a pointer to the ILCode.


Suggested change

// save a pointer to the ILCode.

// saves a pointer to the ILCode.

stephentoub · 2019-11-26T14:33:12Z

src/coreclr/src/ilasm/prebuilt/asmparse.cpp

+				**  we're pretty sure the caller wants a 'for' loop. without
 				**  setting the flag, when we're almost absolutely sure, we'll
-				**  give him one, since the only thing we can shift on this
+				**  give them one, since the only thing we can shift on this


Suggested change

** give them one, since the only thing we can shift on this

** give it one, since the only thing we can shift on this

stephentoub · 2019-11-26T14:34:37Z

src/coreclr/src/vm/crst.h

 //    The fundamental rule of the hierarchy that threads can only request
 //    a crst whose level is lower than any crst currently held by the thread.
-//    E.g. if a thread current holds a level-3 crst, he can try to enter
+//    E.g. if a thread current holds a level-3 crst, it can try to enter


Suggested change

// E.g. if a thread current holds a level-3 crst, it can try to enter

// E.g. if a thread currently holds a level-3 crst, it can try to enter

stephentoub · 2019-11-26T14:34:57Z

src/coreclr/src/vm/methoditer.cpp

    _ASSERTE_MSG(
        *pDomainAssemblyHolder == dbg_m_pDomainAssembly,
-        "Caller probably modified the assembly holder, which he shouldn't - see method comment.");
+        "Caller probably modified the assembly holder, which they shouldn't - see method comment.");


Suggested change

"Caller probably modified the assembly holder, which they shouldn't - see method comment.");

"Caller probably modified the assembly holder, which it shouldn't - see method comment.");

stephentoub · 2019-11-26T14:36:05Z

src/coreclr/tests/src/GC/Stress/Framework/LoaderClass.cs

-/// The LoaderClass is how we communicate with other app domains.  He has to do 3 important things:  1) Load assemblies into the
+/// The LoaderClass is how we communicate with other app domains.  It has to do 3 important things:  1) Load assemblies into the
 /// remote app domain (via Load/LoadFrom), 2) get back an object which represents the test (this is either an I...RelibilityTest or 
 /// a string indicating the assembly to run) (via GetTest), and 3) verify  that our app domain is still running & healthy (via StillAlive)


Suggested change

/// a string indicating the assembly to run) (via GetTest), and 3) verify that our app domain is still running & healthy (via StillAlive)

/// a string indicating the assembly to run) (via GetTest), and 3) verify that our app domain is still running and healthy (via StillAlive)

stephentoub · 2019-11-26T14:36:48Z

src/libraries/System.Data.Common/tests/System/Data/DataColumnTest2.cs

                Assert.Equal(val, dr["computedCol"]);
            }
-            //Now reset the expression and check that the column got his deafult value
+            //Now reset the expression and check that the column got its deafult value


Suggested change

//Now reset the expression and check that the column got its deafult value

// Now reset the expression and check that the column got its default value

stephentoub · 2019-11-26T14:38:40Z

src/libraries/System.Threading.Tasks/tests/CancellationTokenTests.cs

                var linkedTokenSource = CancellationTokenSource.CreateLinkedTokenSource(cts2Token, userToken);

-                // User calls Cancel() on his CTS and then Dispose()
+                // User calls Cancel() on their CTS and then Dispose()


Suggested change

// User calls Cancel() on their CTS and then Dispose()

// User calls Cancel() and then Dispose() on the CTS

Merge from dotnet/runtime

Remove references to gender

7c8cec6

scalablecory approved these changes Nov 26, 2019

View reviewed changes

ViktorHofer approved these changes Nov 26, 2019

View reviewed changes

ViktorHofer merged commit 1289438 into dotnet:master Nov 26, 2019

stephentoub reviewed Nov 26, 2019

View reviewed changes

MichalStrehovsky pushed a commit to MichalStrehovsky/runtime that referenced this pull request Nov 4, 2020

Merge pull request dotnet#262 from jkotas/runtime-merge

45cf22a

Merge from dotnet/runtime

ghost locked as resolved and limited conversation to collaborators Dec 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove references to gender#262

Remove references to gender#262
ViktorHofer merged 1 commit intodotnet:masterfrom
drewnoakes:remove-gender

drewnoakes commented Nov 26, 2019

Uh oh!

scalablecory left a comment •

edited

Loading

Uh oh!

ViktorHofer commented Nov 26, 2019

Uh oh!

stephentoub Nov 26, 2019

Uh oh!

stephentoub Nov 26, 2019

Uh oh!

stephentoub Nov 26, 2019

Uh oh!

stephentoub Nov 26, 2019

Uh oh!

stephentoub Nov 26, 2019

Uh oh!

stephentoub Nov 26, 2019

Uh oh!

stephentoub Nov 26, 2019

Uh oh!

stephentoub Nov 26, 2019

Uh oh!

stephentoub Nov 26, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	Sometimes you might find yourself building the equivalent of a critical section, but using an event directly. The problem here is that we cannot identify the thread that owns the lock, because the owner isn't identified until they "leave'" the lock by calling SetEvent or Pulse. Consider whether a Crst might be more appropriate.
	Sometimes you might find yourself building the equivalent of a critical section, but using an event directly. The problem here is that we cannot identify the thread that owns the lock, because the owner isn't identified until they "leave" the lock by calling SetEvent or Pulse. Consider whether a Crst might be more appropriate.

	// instrumentation later. Of course the only way it will still be accessible to our caller is if they
	// instrumentation later. Of course the only way it will still be accessible to our caller is if it

	// save a pointer to the ILCode.
	// saves a pointer to the ILCode.

	** give them one, since the only thing we can shift on this
	** give it one, since the only thing we can shift on this

	// E.g. if a thread current holds a level-3 crst, it can try to enter
	// E.g. if a thread currently holds a level-3 crst, it can try to enter

	"Caller probably modified the assembly holder, which they shouldn't - see method comment.");
	"Caller probably modified the assembly holder, which it shouldn't - see method comment.");

	/// a string indicating the assembly to run) (via GetTest), and 3) verify that our app domain is still running & healthy (via StillAlive)
	/// a string indicating the assembly to run) (via GetTest), and 3) verify that our app domain is still running and healthy (via StillAlive)

	//Now reset the expression and check that the column got its deafult value
	// Now reset the expression and check that the column got its default value

	// User calls Cancel() on their CTS and then Dispose()
	// User calls Cancel() and then Dispose() on the CTS

Conversation

drewnoakes commented Nov 26, 2019

Uh oh!

scalablecory left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ViktorHofer commented Nov 26, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

scalablecory left a comment •

edited

Loading