Remove unused FreeBSD OSPlatform extension from TargetInfo.cs#126612
Merged
Remove unused FreeBSD OSPlatform extension from TargetInfo.cs#126612
Conversation
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/df11f8a7-851c-4999-8515-2ef58875e47b Co-authored-by: elinor-fung <47805090+elinor-fung@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
elinor-fung
April 7, 2026 19:03
View session
Contributor
|
Tagging subscribers to this area: @agocke, @elinor-fung |
jkotas
approved these changes
Apr 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a now-unused extension(OSPlatform) block in TargetInfo.cs that previously existed solely to provide a FreeBSD OSPlatform value under NETFRAMEWORK. The remaining extension(Architecture) block is kept to support the still-used Architecture.LoongArch64 reference.
Changes:
- Removed the unused
OSPlatformFreeBSD extension member under#if NETFRAMEWORK. - Kept the
Architecture.LoongArch64extension member used by the alignment logic.
radekdoulik
pushed a commit
to radekdoulik/runtime
that referenced
this pull request
Apr 9, 2026
…#126612) Per dotnet#126437 (comment), the `FreeBSD` `OSPlatform` extension in `PlatformExtensions` was defined but never used after PR dotnet#126437 removed its only usage. This PR removes the unused `extension(OSPlatform)` block while keeping the still-used `extension(Architecture)` block for `LoongArch64`. cc @elinor-fung @am11 Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: elinor-fung <47805090+elinor-fung@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #126437 (comment), the
FreeBSDOSPlatformextension inPlatformExtensionswas defined but never used after PR #126437 removed its only usage. This PR removes the unusedextension(OSPlatform)block while keeping the still-usedextension(Architecture)block forLoongArch64.cc @elinor-fung @am11