Keep the trimming target type around if there's a template type layout for the trimming target#126382
Merged
jkoritzinsky merged 7 commits intodotnet:mainfrom Apr 6, 2026
Merged
Conversation
…t for the trimming target Contributes to dotnet#126177
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts NativeAOT dependency tracking for external type map entries so that trim-target types which can be canonically constructed by the runtime type loader also keep the relevant template type layout reachable.
Changes:
- Add a conditional dependency from the trim target type to the canonical template type layout when the trim target has a distinct canonical form.
- Ensures the template layout for the canonical form is present when the trim target type is kept due to an external type map entry.
Member
|
Could you add a regression test too? |
Member
|
Build break in the test |
This was referenced Apr 1, 2026
Open
src/tests/nativeaot/SmokeTests/TrimmingBehaviors/DeadCodeElimination.cs
Outdated
Show resolved
Hide resolved
src/tests/nativeaot/SmokeTests/TrimmingBehaviors/DeadCodeElimination.cs
Outdated
Show resolved
Hide resolved
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/ExternalTypeMapNode.cs
Outdated
Show resolved
Hide resolved
src/tests/nativeaot/SmokeTests/TrimmingBehaviors/DeadCodeElimination.cs
Outdated
Show resolved
Hide resolved
…nation.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/ExternalTypeMapNode.cs
Show resolved
Hide resolved
MichalStrehovsky
approved these changes
Apr 6, 2026
969e6cf to
dd72bae
Compare
Member
Author
|
/ba-g this already ran CI on this commit and passed. I messed up the commit trigger and re-pushed the same commit. |
radekdoulik
pushed a commit
to radekdoulik/runtime
that referenced
this pull request
Apr 9, 2026
…t for the trimming target (dotnet#126382) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #126177