Skip to content

Bump picomatch in /src/native#126131

Open
dependabot[bot] wants to merge 2 commits intomainfrom
dependabot/npm_and_yarn/src/native/multi-bf05dc1ecf
Open

Bump picomatch in /src/native#126131
dependabot[bot] wants to merge 2 commits intomainfrom
dependabot/npm_and_yarn/src/native/multi-bf05dc1ecf

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot bot commented on behalf of github Mar 25, 2026

Bumps and picomatch. These dependencies needed to be updated together.
Updates picomatch from 4.0.3 to 4.0.4

Release notes

Sourced from picomatch's releases.

4.0.4

This is a security release fixing several security relevant issues.

What's Changed

Full Changelog: micromatch/picomatch@4.0.3...4.0.4

Commits

Updates picomatch from 2.3.1 to 2.3.2

Release notes

Sourced from picomatch's releases.

4.0.4

This is a security release fixing several security relevant issues.

What's Changed

Full Changelog: micromatch/picomatch@4.0.3...4.0.4

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps  and [picomatch](https://github.com/micromatch/picomatch). These dependencies needed to be updated together.

Updates `picomatch` from 4.0.3 to 4.0.4
- [Release notes](https://github.com/micromatch/picomatch/releases)
- [Changelog](https://github.com/micromatch/picomatch/blob/master/CHANGELOG.md)
- [Commits](micromatch/picomatch@4.0.3...4.0.4)

Updates `picomatch` from 2.3.1 to 2.3.2
- [Release notes](https://github.com/micromatch/picomatch/releases)
- [Changelog](https://github.com/micromatch/picomatch/blob/master/CHANGELOG.md)
- [Commits](micromatch/picomatch@4.0.3...4.0.4)

---
updated-dependencies:
- dependency-name: picomatch
  dependency-version: 4.0.4
  dependency-type: indirect
- dependency-name: picomatch
  dependency-version: 2.3.2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@github-actions
Copy link
Copy Markdown
Contributor

🤖 Copilot Code Review — PR #126131

Note

This review was generated by Copilot.

Holistic Assessment

Motivation: Justified. Both picomatch bumps (4.0.3→4.0.4 and 2.3.1→2.3.2) include a security fix that limits nested extglob depth to mitigate a ReDoS (Regular Expression Denial of Service) vulnerability. The upstream commits add a maxExtglobRecursion option and treat risky globs as literals.

Approach: Correct. This is a standard dependabot-generated package-lock.json update for indirect dev dependencies. Only the lock file changed — no package.json change is needed since picomatch is a transitive dependency (pulled in via micromatch/fast-glob).

Summary: ✅ LGTM. This is a low-risk, automated security patch for dev-only indirect dependencies. The changes are consistent with the existing codebase patterns and have no impact on the .NET runtime build output.


Detailed Findings

✅ Security fix — ReDoS mitigation in picomatch

Both picomatch 4.0.4 and 2.3.2 include the same security fix (upstream commit): adding a maximum nested extglob recursion depth and treating risky globs as literals. This addresses a known ReDoS vector via deeply nested extglob patterns.

✅ Scope — Dev-only, no runtime impact

Both picomatch entries are marked "dev": true and "dependency-type": "indirect". They are used by the JavaScript build toolchain (rollup, eslint, fast-glob) in src/native/ for the WASM/JS interop build. No .NET runtime, library, or test code is affected.

💡 Integrity hash algorithm — sha512 → sha1

The integrity hashes changed from sha512- to sha1- because the resolved registry changed from registry.npmjs.org to pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public-npm/npm/registry/ (the Azure DevOps mirror configured in src/native/.npmrc). SHA-1 is a weaker integrity algorithm than SHA-512, but this is a pre-existing pattern — 52 other entries in this lock file already use sha1- hashes from the same registry. This is expected behavior from the Azure DevOps npm feed and is not a concern introduced by this PR.

Generated by Code Review for issue #126131 ·

@danmoseley
Copy link
Copy Markdown
Member

@agocke ok to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-codeflow for labeling automated codeflow dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant