Set MSBUILDDEBUGPATH in CI so MSBuild crash diagnostics are preserved#126012
Merged
danmoseley merged 2 commits intodotnet:mainfrom Mar 26, 2026
Merged
Set MSBUILDDEBUGPATH in CI so MSBuild crash diagnostics are preserved#126012danmoseley merged 2 commits intodotnet:mainfrom
danmoseley merged 2 commits intodotnet:mainfrom
Conversation
When MSBuild worker nodes crash during builds (dotnet#92290), diagnostic failure.txt files are written to a system temp directory on the ephemeral agent and lost. This sets MSBUILDDEBUGPATH to a path under artifacts/log/ so the existing always-on log publishing step picks them up automatically. The coreclr build scripts already set this for their specific build steps, but this covers all build legs including the macOS libs/mono builds that are currently hitting the issue. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CI global build job template to set MSBUILDDEBUGPATH so MSBuild crash diagnostics (e.g., MSBuild_*.failure.txt) are written under artifacts/log/... and can be published with build logs instead of being lost in ephemeral agent temp directories.
Changes:
- Add a job-level
MSBUILDDEBUGPATHpipeline variable in the global build job template. - Point
MSBUILDDEBUGPATHatartifacts/log/<config>/MsbuildDebugLogsto align with existing log publishing.
This was referenced Mar 24, 2026
Open
Member
Author
|
@copilot handle feedback |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Mar 25, 2026
Member
Author
|
/ba-g unrelated build timeout |
hoyosjs
approved these changes
Mar 26, 2026
Member
Author
|
/ba-g build timeout |
danmoseley
added a commit
to danmoseley/runtime
that referenced
this pull request
Apr 12, 2026
…rash diagnostics The MSBUILDDEBUGPATH pipeline variable added in PR dotnet#126012 is not reaching the MSBuild process during Build product steps. Set the env var directly in the build scripts, matching the existing pattern in build-runtime.sh and tests/build.sh. Also create the directory with mkdir -p / New-Item -Force to avoid issues with MSBuild's EnsureDirectoryExists (which has no try/catch in its static constructor). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR was generated with the help of GitHub Copilot.
Set
MSBUILDDEBUGPATHin CI so MSBuild crash diagnostics are preserved in more build types.When MSBuild worker nodes crash during CI builds (see #92290), diagnostic
MSBuild_*.failure.txtfiles are written to a system temp directory on the ephemeral build agent and lost when the agent is cleaned up. This makes it impossible to determine the root cause of the crashes.Several component-specific build scripts (
src/coreclr/build-runtime.sh,src/tests/build.sh,src/native/corehost/build.sh) already setMSBUILDDEBUGPATHtoartifacts/log/<config>/MsbuildDebugLogs, but the top-level build invoked by the pipeline template (global-build-step.yml) does not. Build legs that don't go through one of those component scripts — such as the macOS libs/mono builds currently hitting #92290 — get the default temp dir.This adds
MSBUILDDEBUGPATHas a job-level pipeline variable inglobal-build-job.yml, pointing to the sameartifacts/log/<config>/MsbuildDebugLogspath. The existingcondition: always()log publishing step injob.ymlalready sweepsartifacts/log/, so the failure diagnostics will be automatically published as build artifacts the next time a crash occurs.