Skip to content

Fix Mono-style whitespace in UnsafeMethodMissingRequiresUnsafeAnalyze…#125943

Merged
MichalStrehovsky merged 1 commit intodotnet:mainfrom
MichalStrehovsky:whitespace
Apr 7, 2026
Merged

Fix Mono-style whitespace in UnsafeMethodMissingRequiresUnsafeAnalyze…#125943
MichalStrehovsky merged 1 commit intodotnet:mainfrom
MichalStrehovsky:whitespace

Conversation

@MichalStrehovsky
Copy link
Copy Markdown
Member

…r.cs

Remove spaces before parentheses in method calls/declarations and switch from K&R to Allman brace style to match the rest of the ILLink.RoslynAnalyzer codebase.

…r.cs

Remove spaces before parentheses in method calls/declarations and
switch from K&R to Allman brace style to match the rest of the
ILLink.RoslynAnalyzer codebase.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@MichalStrehovsky MichalStrehovsky requested a review from agocke March 23, 2026 04:40
Copilot AI review requested due to automatic review settings March 23, 2026 04:40
@github-actions github-actions bot added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Mar 23, 2026
@dotnet-policy-service dotnet-policy-service bot added the linkable-framework Issues associated with delivering a linker friendly framework label Mar 23, 2026
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @agocke, @dotnet/illink
See info in area-owners.md if you want to be subscribed.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes formatting in UnsafeMethodMissingRequiresUnsafeAnalyzer to match the existing ILLink.RoslynAnalyzer style (no spaces before parentheses and consistent Allman brace placement).

Changes:

  • Removed spaces before parentheses in method calls/declarations.
  • Converted K&R-style braces in lambdas/loops to Allman-style blocks.

@MichalStrehovsky
Copy link
Copy Markdown
Member Author

@dotnet/illink could someone have a look please?

@MichalStrehovsky
Copy link
Copy Markdown
Member Author

@dotnet/illink could someone have a look please?

Anyone for a whitespace only change?

@MichalStrehovsky
Copy link
Copy Markdown
Member Author

/ba-g helix workitem crash on wasm that is not related to a whitespace change

@MichalStrehovsky MichalStrehovsky merged commit 1f4f1ff into dotnet:main Apr 7, 2026
88 of 90 checks passed
@MichalStrehovsky MichalStrehovsky deleted the whitespace branch April 7, 2026 23:57
radekdoulik pushed a commit to radekdoulik/runtime that referenced this pull request Apr 9, 2026
dotnet#125943)

Remove spaces before parentheses in method calls/declarations and switch
from K&R to Allman brace style to match the rest of the
ILLink.RoslynAnalyzer codebase.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-Tools-ILLink .NET linker development as well as trimming analyzers linkable-framework Issues associated with delivering a linker friendly framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants