Use a platform-neutral name for Microsoft.DiaSymReader.Native#125165
Merged
akoeplinger merged 5 commits intodotnet:mainfrom Mar 4, 2026
Merged
Use a platform-neutral name for Microsoft.DiaSymReader.Native#125165akoeplinger merged 5 commits intodotnet:mainfrom
Microsoft.DiaSymReader.Native#125165akoeplinger merged 5 commits intodotnet:mainfrom
Conversation
Fixes issues that we're running into when rebootstrapping the dotnet/dotnet build (dotnet/dotnet#5155 (comment)). `Microsoft.DiaSymReader.Native.(x86|x64|arm64).dll` clashes with the same name DLL in the runtime pack. Not having a suffix is simpler in the end.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates CoreCLR tooling to use a platform-neutral Microsoft.DiaSymReader.Native.dll name (instead of arch-suffixed names) to avoid DLL name clashes during dotnet/dotnet build bootstrapping.
Changes:
- Update crossgen2 publishing/layout to copy/link DiaSymReader native binary as
Microsoft.DiaSymReader.Native.dll. - Simplify
PdbWriternative library loading by removing the customDllImportResolver(now relying on default resolution). - Add
Microsoft.DiaSymReader.Native.dllto the SuperPMI collection ignore list.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/coreclr/tools/aot/crossgen2/crossgen2.props | Renames the copied DiaSymReader native asset to a platform-neutral filename in crossgen2 output/publish. |
| src/coreclr/tools/aot/ILCompiler.Diagnostics/PdbWriter.cs | Removes custom native DLL resolver so LibraryImport resolves via default loader behavior. |
| src/coreclr/scripts/superpmi_collect_setup.py | Ignores the new neutral DiaSymReader DLL during SuperPMI payload partitioning. |
You can also share your feedback on Copilot code review. Take the survey.
This reverts commit c9d90b8.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
You can also share your feedback on Copilot code review. Take the survey.
ViktorHofer
approved these changes
Mar 4, 2026
akoeplinger
approved these changes
Mar 4, 2026
MichalStrehovsky
added a commit
to MichalStrehovsky/runtime
that referenced
this pull request
Mar 9, 2026
I always wondered why we need to AOT compile ilc and crossgen2 twice, but never cared enough. With copilot cli I'm building clr.tools more often, so it crossed the threshold for me caring: * I don't think we ever needed to do this for ilc * We _possibly_ don't need this for crossgen2 after dotnet#125165
MichalStrehovsky
added a commit
that referenced
this pull request
Mar 10, 2026
I always wondered why we need to AOT compile ilc and crossgen2 twice, but never cared enough. With copilot cli I'm building clr.tools more often, so it crossed the threshold for me caring: * I don't think we ever needed to do this for ilc * We _possibly_ don't need this for crossgen2 after #125165
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issues that we're running into when rebootstrapping the dotnet/dotnet build (dotnet/dotnet#5155 (comment)).
Microsoft.DiaSymReader.Native.(x86|x64|arm64).dllclashes with the same name DLL in the runtime pack. Not having a suffix is simpler in the end.Cc @dotnet/appmodel