[HTTP] Re-enable GetAsync_CancelDuringResponseBodyReceived_Buffered test#124594
Merged
ManickaP merged 3 commits intodotnet:mainfrom Feb 23, 2026
Merged
[HTTP] Re-enable GetAsync_CancelDuringResponseBodyReceived_Buffered test#124594ManickaP merged 3 commits intodotnet:mainfrom
ManickaP merged 3 commits intodotnet:mainfrom
Conversation
Remove the ActiveIssue attribute disabling this cancellation test. The original failure was a timing assertion where elapsed time (31.67s) exceeded a 30-second threshold. The threshold has since been increased to 60 seconds in ValidateClientCancellationAsync, which provides sufficient margin for CI environments under load. Fixes dotnet#25760 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Re-enables a previously disabled HttpClient cancellation functional test now that the shared cancellation timing threshold has been relaxed to better tolerate slower CI environments.
Changes:
- Removed the
[ActiveIssue]suppression fromGetAsync_CancelDuringResponseBodyReceived_Buffered_TaskCanceledQuickly.
MihaZupan
approved these changes
Feb 19, 2026
Member
Author
|
Re-enabled test seems to be running successfully, e.g.: |
Member
Author
|
Getting timeouts on WinHttpHandler: Investigating. |
WinHttpHandler does not observe cancellation during buffered response body reads (HttpCompletionOption.ResponseContentRead), causing the test to hang indefinitely. Skip it for WinHttpHandler while keeping it enabled for SocketsHttpHandler. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
So this test needs to stay disabled on .NET Framework, we're not passing |
MihaZupan
approved these changes
Feb 23, 2026
iremyux
pushed a commit
to iremyux/dotnet-runtime
that referenced
this pull request
Mar 2, 2026
…est (dotnet#124594) Remove the `ActiveIssue` attribute disabling this cancellation test. The original failure was a timing assertion where elapsed time (31.67s) exceeded a 30-second threshold. The threshold has since been increased to 60 seconds in `ValidateClientCancellationAsync`, which provides sufficient margin for CI environments under load. Fixes dotnet#25760 --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
ActiveIssueattribute disabling this cancellation test. The original failure was a timing assertion where elapsed time (31.67s) exceeded a 30-second threshold. The threshold has since been increased to 60 seconds inValidateClientCancellationAsync, which provides sufficient margin for CI environments under load.Fixes #25760