Use Contains in FileSystemName.MatchPattern#123900
Merged
stephentoub merged 1 commit intodotnet:mainfrom Feb 3, 2026
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-io |
MihaZupan
approved these changes
Feb 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the FileSystemName.MatchPattern method to use the built-in Contains method instead of a manual loop when checking for additional periods in a filename during DOS_STAR wildcard matching.
Changes:
- Replaced a manual for-loop with
ReadOnlySpan<char>.Contains('.')for better code clarity and maintainability
MihaZupan
reviewed
Feb 2, 2026
src/libraries/System.Private.CoreLib/src/System/IO/Enumeration/FileSystemName.cs
Show resolved
Hide resolved
This was referenced Feb 3, 2026
Member
Author
|
/ba-g mono timeouts |
lewing
pushed a commit
to lewing/runtime
that referenced
this pull request
Feb 9, 2026
iremyux
pushed a commit
to iremyux/dotnet-runtime
that referenced
this pull request
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.